Repository navigation
fix(oauth): use transparent egress in Linux guests - #849
Merged
dofastted merged 2 commits intoNov 2, 2026
Merged
Conversation
cursor
Bot
force-pushed
the
fix/oauth-guest-transparent-egress
branch
2 times, most recently
from
November 2, 2026 11:42
e16ae0d to
080ac21
Compare
Co-authored-by: ted <kuhlmangarry24@gmail.com>
cursor
Bot
force-pushed
the
fix/oauth-guest-transparent-egress
branch
from
November 2, 2026 11:42
080ac21 to
ca69d3e
Compare
Keep both Unreleased notes: the cleanup already on main, and dofastted#848.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #848.
Linux guest OAuth now always leaves egress selection to the slot's existing
kin-eg-*transparent network. It no longer forwards the VM binding URL intokin-oauth-auth.Root cause
runGuestOAuthAuthServicepreviously sentboundProxyUrl(vm.proxy)unless the binding waspx-local. A controller-side SOCKS forwarder stored as127.0.0.1:20881was therefore forwarded into the Docker/KVM guest, where loopback points at the guest itself and token exchange failed withECONNREFUSED.The slot already joins its bound transparent egress network, and its worker uses an empty
proxy_urlin that mode. This change applies the same rule to guest OAuth.Changes
proxy_url: ''to non-native guest OAuth helpers; the macOS native path still returns before this code and keeps its original payload.prepare/runDockerand verifies both loopback and remote bindings produce an empty guestproxy_url.This is complementary to #845: #845 avoids the control-plane bootstrap hop after exchange, while this PR fixes the guest helper input that still carried the unreachable controller URL.
Tests
npx biome checkon all changed JS tests/source: passed.git diff --check: passed.Risk
Low. Only the non-native Linux guest helper input changes, from a controller-specific proxy URL to the transparent-network contract already used by slot workers. Native macOS behavior is unchanged.