feat(react): announce arrivals, document client sharing#78
Open
soufian3hm wants to merge 1 commit into
Open
Conversation
The two follow-ups deferred from dodopayments#61: a polite status region announces arrivals held behind the new-notification pill, and the docs gain a one-client-per-page section (multiple standalone inboxes each open an SSE connection into the HTTP/1.1 per-origin cap). Refs dodopayments#61
Greptile SummaryThis PR adds accessible arrival announcements and client-sharing guidance. The main changes are:
Confidence Score: 5/5This looks safe to merge.
Important Files Changed
Reviews (1): Last reviewed commit: "feat(react): announce arrivals, document..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completes the last two deferred items from #61 (follow-up to #72, which covers the other four):
role=statusregion carries the same localized text as the pill, so screen-reader users perceive arrivals held behind it without moving focus. Emptied on dismiss. Deliberately scoped to the pill: always-on badge announcements would read every unseen tick during bursts, while the badge count already rides the bell's accessible name (announced on focus, per the audit note).ChimelyProviderclient across multiple inbox surfaces, since each standalone<Inbox />opens its own SSE connection into the browser's ~6-per-origin HTTP/1.1 cap.Verification
biome, build, typecheck, vitest all green: 106 react tests, including a new one pinning the status region (announces on arrival behind the pill, empties on dismiss). Patch changeset included.