feat(react): first-class notification severity#73
Open
soufian3hm wants to merge 1 commit into
Open
Conversation
Frontend slice of the severity feature. WellKnownPayload gains an
optional severity ('high' | 'medium' | 'low'); the default item
renders a left accent tinted by new colorSeverityHigh/Medium/Low
appearance variables. Values outside the set render no accent.
Refs dodopayments#36
Greptile SummaryThis PR adds first-class notification severity to the frontend packages. The main changes are:
Confidence Score: 5/5This looks safe to merge.
Important Files Changed
Reviews (1): Last reviewed commit: "feat(react): first-class notification se..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #36.
Frontend slice of first-class notification severity.
What
@chimely/client:WellKnownPayloadgains an optionalseverity: 'high' | 'medium' | 'low'-- additive, in keeping with its "only ever gains optional fields" contract.@chimely/react: the default item renders a left accent bar tinted by three new appearance variables --colorSeverityHigh(#dc2626),colorSeverityMedium(#d97706),colorSeverityLow(#2563eb). The accent is decorative (aria-hidden); the value already rides the item text.severityvia theirfilterpredicate, per the issue.Deferred (as the issue frames it)
Verification
biome,pnpm --filter "./packages/*" build, typecheck, and vitest are all green:@chimely/client54 tests and@chimely/react108 tests, including 3 new ones (known-severity accent, no accent without severity, and an out-of-set value rendering nothing). A minor changeset covers both packages.