build(release): attach npm provenance on publish#71
Merged
Conversation
Set publishConfig.provenance in both SDK packages so attestations attach independent of NPM_CONFIG_PROVENANCE, which did not survive the changesets -> pnpm publish chain (0.2.1 published without dist.attestations). The release workflow env stays as belt and braces. Closes dodopayments#65
Greptile SummaryThis PR enables npm provenance for the published SDK packages. The main changes are:
Confidence Score: 5/5This looks safe to merge.
Important Files Changed
Reviews (1): Last reviewed commit: "build(release): attach npm provenance on..." | Re-trigger Greptile |
Member
|
@soufian3hm thanks for the contribution! please remove the changeset as it's not needed for this change. |
Contributor
Author
|
@that-ambuj Done ✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #65.
NPM_CONFIG_PROVENANCE: trueran on the 0.2.1 publish withid-token: writeon a public repo, but the tarballs carried nodist.attestations-- the env var did not survive thechangesets -> pnpm publishchain.This applies the durable fix from the issue: set
"publishConfig": { "provenance": true }in both SDK packages. It is tool-agnostic (no env plumbing), so provenance attaches on the next publish regardless of howpnpm publishis invoked. The release workflow's visibility-gatedNPM_CONFIG_PROVENANCEis left in place as belt and braces.Changes
packages/client/package.json,packages/react/package.json: addprovenance: trueto the existingpublishConfig.dist.attestationsexists afterward).Verification
pnpm install --frozen-lockfile,pnpm lint(biome),pnpm --filter "./packages/*" build, and typecheck + vitest for@chimely/client+@chimely/reactall pass (159 tests).