Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,7 @@
"package_decision_bundle_validation": "docs/validation/milestone-e-package-publication-decision-bundle-validation-2026-06-21.md",
"package_pre_approval_gap_ledger": "docs/validation/milestone-e-package-publication-pre-approval-gap-ledger-validation-2026-06-21.md",
"package_decision_input_packet": "docs/validation/milestone-e-package-publication-decision-input-packet-validation-2026-06-21.md",
"package_approval_readiness_review": "docs/validation/milestone-e-package-publication-approval-readiness-review-validation-2026-06-21.md",
}
EXPECTED_PUBLICATION_DECISION_INPUTS = {
"decision_status": "not_approved_pending_exact_decision",
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,195 @@
#!/usr/bin/env python3
#
# Copyright 2026 The Ethos maintainers
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
#

from __future__ import annotations

import json
import re
import subprocess
import unittest
from pathlib import Path

from makefile_guard import target_block


ROOT = Path(__file__).resolve().parents[2]
PREP = ROOT / "docs/milestone-e-package-publication-approval-prep.json"
RECORD = (
ROOT
/ "docs/validation/"
"milestone-e-package-publication-approval-readiness-review-validation-2026-06-21.md"
)
VALIDATION_README = ROOT / "docs/validation/README.md"
PREP_SCOPE = ROOT / "docs/milestone-e-prep-scope.md"
ROADMAP = ROOT / "docs/roadmap.md"
EXECUTION_STATUS = ROOT / "docs/execution-status.md"
CI_WORKFLOW = ROOT / ".github/workflows/ci.yml"

SOURCE_COMMIT = "9054f1c3823b8f0ff69f0776b60060b642705e28"
SOURCE_SHORT = "9054f1c"
SOURCE_TREE = "3f8cb66249826d67ab6030032c7784a2a4ff411b"
FORBIDDEN_SCOPE_EXPANSION = [
"public reports are approved",
"public result wording approved",
"release-ready",
"release artifact approved",
"package-ready",
"package publication is approved",
"package publication approved",
"packages are published",
"published packages",
"production-ready",
"production positioning approved",
"benchmark-validated",
"public benchmark pass",
"speed validated",
"fastest",
"launch-ready",
"hosted surface approved",
"hosted demo approved",
"demo-ready",
"performance validated",
"quality validated",
"footprint validated",
"table-quality validated",
"parser-quality validated",
]


def read(path: Path) -> str:
return path.read_text(encoding="utf-8")


def normalized(path: Path) -> str:
return re.sub(r"\s+", " ", read(path))


def load_json(path: Path) -> dict:
return json.loads(path.read_text(encoding="utf-8"))


def git(*args: str) -> str:
return subprocess.check_output(
["git", *args],
cwd=ROOT,
encoding="utf-8",
stderr=subprocess.DEVNULL,
).strip()


class MilestoneEPackagePublicationApprovalReadinessReviewTests(unittest.TestCase):
def test_readiness_record_is_indexed_and_source_bound(self) -> None:
prep = load_json(PREP)
readme = read(VALIDATION_README)
record = normalized(RECORD)

self.assertIn(RECORD.name, readme)
self.assertIn("package publication approval-readiness review validation", re.sub(r"\s+", " ", readme))
self.assertEqual(
"docs/validation/milestone-e-package-publication-approval-readiness-review-validation-2026-06-21.md",
prep["follow_up_records"]["package_approval_readiness_review"],
)
self.assertIn(f"Validated source HEAD before this record: `{SOURCE_SHORT}`", read(RECORD))
self.assertIn(f"Readiness review source commit: `{SOURCE_COMMIT}`", record)
self.assertIn(f"Readiness review source tree: `{SOURCE_TREE}`", record)
self.assertEqual(SOURCE_COMMIT, git("rev-parse", SOURCE_SHORT))
self.assertEqual(SOURCE_TREE, git("rev-parse", f"{SOURCE_SHORT}^{{tree}}"))

def test_readiness_review_summarizes_present_inputs_and_remaining_blockers(self) -> None:
prep = load_json(PREP)
packet = prep["package_publication_decision_input_packet"]
record = normalized(RECORD)

self.assertEqual("decision_input_packet_recorded_publication_blocked", packet["packet_state"])
for crate in packet["candidate_crates"]:
self.assertIn(crate, record)
for version in packet["candidate_version_map"]:
self.assertIn(version, record)
for tag in packet["candidate_package_tag_names"]:
self.assertIn(tag, record)
for candidate_diff in packet["candidate_manifest_activation_diff"]:
self.assertIn(candidate_diff, record)
for blocker in packet["retained_blockers"]:
self.assertIn(blocker, record)
self.assertIn("exact package publication approval decision record remains required", record)
self.assertIn("registry-backed dependent package assembly evidence remains required", record)
self.assertIn("public-surface posture check after exact public installation wording changes remains required", record)
self.assertIn("claims gate after exact public installation wording changes remains required", record)
self.assertIn("make milestone-e-prep after exact decision record remains required", record)
self.assertIn("Package publication remains blocked", record)
self.assertIn("Public installation remains blocked", record)

def test_candidate_inputs_do_not_activate_tags_or_manifests(self) -> None:
packet = load_json(PREP)["package_publication_decision_input_packet"]
core_manifest = read(ROOT / "crates/ethos-core/Cargo.toml")
verify_manifest = read(ROOT / "crates/ethos-verify/Cargo.toml")
pdf_manifest = read(ROOT / "crates/ethos-pdf/Cargo.toml")

for value in packet["candidate_package_tag_names"]:
tag = value.split(": ", maxsplit=1)[1].split(";", maxsplit=1)[0]
self.assertEqual("", git("tag", "--list", tag))
self.assertIn('name = "ethos-core"', core_manifest)
self.assertIn('reserved_crates_io_name = "ethos-doc-core"', core_manifest)
self.assertIn("publish = false", core_manifest)
self.assertIn('name = "ethos-verify"', verify_manifest)
self.assertIn("publish = false", verify_manifest)
self.assertIn('name = "ethos-pdf"', pdf_manifest)
self.assertIn("publish = false", pdf_manifest)
self.assertNotIn('package = "ethos-doc-core"', verify_manifest)
self.assertNotIn('package = "ethos-doc-core"', pdf_manifest)

def test_docs_reference_readiness_review_and_blockers(self) -> None:
for path in (PREP_SCOPE, ROADMAP, EXECUTION_STATUS, VALIDATION_README):
doc = normalized(path)

self.assertIn(RECORD.name, doc, str(path))
self.assertIn("package publication approval readiness review", doc.lower(), str(path))
self.assertIn("package publication remains blocked", doc, str(path))
self.assertIn("public installation remains blocked", doc, str(path))

def test_make_and_ci_run_readiness_review_after_decision_input_packet(self) -> None:
make_block = target_block("milestone-e-prep")
ci = read(CI_WORKFLOW)
packet_guard = "test_milestone_e_package_publication_decision_input_packet.py"
readiness_guard = "test_milestone_e_package_publication_approval_readiness_review.py"
public_facing_guard = "test_milestone_e_public_facing_readiness_ledger.py"

for text, prefix in ((make_block, "$(PYTHON) .github/scripts/"), (ci, "python3 .github/scripts/")):
self.assertIn(prefix + readiness_guard, text)
self.assertEqual(1, text.count(prefix + readiness_guard))
self.assertLess(text.index(prefix + packet_guard), text.index(prefix + readiness_guard))
self.assertLess(text.index(prefix + readiness_guard), text.index(prefix + public_facing_guard))

def test_record_avoids_scope_expansion_language_or_private_paths(self) -> None:
lower = normalized(RECORD).lower()
raw = read(RECORD)

for phrase in FORBIDDEN_SCOPE_EXPANSION:
self.assertNotIn(phrase, lower)
self.assertNotIn("/Users/", raw)
self.assertNotIn("/private/tmp", raw)
self.assertNotIn("/private/var", raw)
self.assertNotIn("/var/folders", raw)
self.assertNotIn("saumildiwaker", raw)
self.assertNotIn("Desktop/Stuff", raw)
self.assertNotIn("project/repo/ethos", raw)
self.assertNotIn("docs/.roadmap.md.swp", raw)
self.assertNotIn("web/", raw)


if __name__ == "__main__":
unittest.main()
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,7 @@
"$(PYTHON) .github/scripts/test_milestone_e_package_publication_pre_approval_gap_ledger.py",
"$(PYTHON) .github/scripts/test_milestone_e_package_publication_approval_resolution_plan.py",
"$(PYTHON) .github/scripts/test_milestone_e_package_publication_decision_input_packet.py",
"$(PYTHON) .github/scripts/test_milestone_e_package_publication_approval_readiness_review.py",
"$(PYTHON) .github/scripts/test_milestone_e_public_facing_readiness_ledger.py",
"$(PYTHON) .github/scripts/test_milestone_e_public_beta_current_main_refresh_prep.py",
"$(PYTHON) .github/scripts/test_milestone_e_public_beta_current_main_source_only_approval.py",
Expand Down
1 change: 1 addition & 0 deletions .github/scripts/test_milestone_e_prep_scope.py
Original file line number Diff line number Diff line change
Expand Up @@ -407,6 +407,7 @@ def test_make_target_is_narrow_and_guarded(self) -> None:
"$(PYTHON) .github/scripts/test_milestone_e_package_publication_pre_approval_gap_ledger.py",
"$(PYTHON) .github/scripts/test_milestone_e_package_publication_approval_resolution_plan.py",
"$(PYTHON) .github/scripts/test_milestone_e_package_publication_decision_input_packet.py",
"$(PYTHON) .github/scripts/test_milestone_e_package_publication_approval_readiness_review.py",
"$(PYTHON) .github/scripts/test_milestone_e_public_facing_readiness_ledger.py",
"$(PYTHON) .github/scripts/test_milestone_e_public_beta_current_main_refresh_prep.py",
"$(PYTHON) .github/scripts/test_milestone_e_public_beta_current_main_source_only_approval.py",
Expand Down
4 changes: 4 additions & 0 deletions .github/scripts/test_milestone_e_validation_record_index.py
Original file line number Diff line number Diff line change
Expand Up @@ -266,6 +266,10 @@ class RecordCoverage:
"milestone-e-package-publication-decision-input-packet-validation-2026-06-21.md",
"test_milestone_e_package_publication_decision_input_packet.py",
),
RecordCoverage(
"milestone-e-package-publication-approval-readiness-review-validation-2026-06-21.md",
"test_milestone_e_package_publication_approval_readiness_review.py",
),
RecordCoverage(
"milestone-e-public-facing-readiness-ledger-validation-2026-06-21.md",
"test_milestone_e_public_facing_readiness_ledger.py",
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -230,6 +230,8 @@ jobs:
run: python3 .github/scripts/test_milestone_e_package_publication_approval_resolution_plan.py
- name: Milestone E package publication decision-input packet tests
run: python3 .github/scripts/test_milestone_e_package_publication_decision_input_packet.py
- name: Milestone E package publication approval-readiness review tests
run: python3 .github/scripts/test_milestone_e_package_publication_approval_readiness_review.py
- name: Milestone E public-facing readiness ledger tests
run: python3 .github/scripts/test_milestone_e_public_facing_readiness_ledger.py
- name: Milestone E public beta current-main refresh prep tests
Expand Down
1 change: 1 addition & 0 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -222,6 +222,7 @@ milestone-e-prep:
$(PYTHON) .github/scripts/test_milestone_e_package_publication_pre_approval_gap_ledger.py
$(PYTHON) .github/scripts/test_milestone_e_package_publication_approval_resolution_plan.py
$(PYTHON) .github/scripts/test_milestone_e_package_publication_decision_input_packet.py
$(PYTHON) .github/scripts/test_milestone_e_package_publication_approval_readiness_review.py
$(PYTHON) .github/scripts/test_milestone_e_public_facing_readiness_ledger.py
$(PYTHON) .github/scripts/test_milestone_e_public_beta_current_main_refresh_prep.py
$(PYTHON) .github/scripts/test_milestone_e_public_beta_current_main_source_only_approval.py
Expand Down
2 changes: 2 additions & 0 deletions docs/execution-status.md
Original file line number Diff line number Diff line change
Expand Up @@ -199,6 +199,8 @@ The package publication approval resolution plan in `docs/validation/milestone-e

The package publication decision input packet in `docs/validation/milestone-e-package-publication-decision-input-packet-validation-2026-06-21.md` records candidate version, tag, source binding, manifest activation, registry-backed assembly, and public installation wording inputs for later review against source commit `54bf70f` / tree `5a197bee718e3b31399563340169e9efd4f1317c`. Package publication remains blocked and public installation remains blocked.

The package publication approval readiness review in `docs/validation/milestone-e-package-publication-approval-readiness-review-validation-2026-06-21.md` records the current readiness status against source commit `9054f1c` / tree `3f8cb66249826d67ab6030032c7784a2a4ff411b`. Exact approval decision, signoff, manifest review, assembly evidence, and post-wording gates remain required while package publication remains blocked and public installation remains blocked.

| Work item | Current status | Remaining blocker |
| --- | --- | --- |
| PDFium Phase 1 profile | Landed: pinned profile, V8/XFA-disabled state, platform hashes, runtime library hashes, and provenance are recorded | Phase 2 project-maintained builds still block Public Beta |
Expand Down
3 changes: 2 additions & 1 deletion docs/milestone-e-package-publication-approval-prep.json
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,8 @@
"package_tag_creation_prep": "docs/validation/milestone-e-package-publication-tag-creation-prep-validation-2026-06-21.md",
"package_decision_bundle_validation": "docs/validation/milestone-e-package-publication-decision-bundle-validation-2026-06-21.md",
"package_pre_approval_gap_ledger": "docs/validation/milestone-e-package-publication-pre-approval-gap-ledger-validation-2026-06-21.md",
"package_decision_input_packet": "docs/validation/milestone-e-package-publication-decision-input-packet-validation-2026-06-21.md"
"package_decision_input_packet": "docs/validation/milestone-e-package-publication-decision-input-packet-validation-2026-06-21.md",
"package_approval_readiness_review": "docs/validation/milestone-e-package-publication-approval-readiness-review-validation-2026-06-21.md"
},
"publication_approval_decision_inputs": {
"decision_status": "not_approved_pending_exact_decision",
Expand Down
5 changes: 5 additions & 0 deletions docs/milestone-e-prep-scope.md
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,11 @@ The package publication decision input packet is recorded in
It binds candidate review inputs to source commit `54bf70f` / tree
`5a197bee718e3b31399563340169e9efd4f1317c` while package publication remains blocked and public
installation remains blocked.
The package publication approval readiness review is recorded in
`docs/validation/milestone-e-package-publication-approval-readiness-review-validation-2026-06-21.md`.
It records readiness status for source commit `9054f1c` / tree
`3f8cb66249826d67ab6030032c7784a2a4ff411b` while package publication remains blocked and public
installation remains blocked.
The metadata-readiness follow-up record under `docs/validation/` covers README, NOTICE, manifest
metadata, and include-list readiness for `ethos-core`, `ethos-verify`, and `ethos-pdf` only.
`ethos-doc` and `ethos-rag` remain reserved placeholders without in-tree package manifests, and
Expand Down
5 changes: 5 additions & 0 deletions docs/roadmap.md
Original file line number Diff line number Diff line change
Expand Up @@ -169,6 +169,11 @@ The package publication decision input packet is recorded in
for source commit `54bf70f` / tree `5a197bee718e3b31399563340169e9efd4f1317c`. Candidate version,
tag, manifest, assembly, and wording inputs are recorded while package publication remains blocked
and public installation remains blocked.
The package publication approval readiness review is recorded in
[`docs/validation/milestone-e-package-publication-approval-readiness-review-validation-2026-06-21.md`](validation/milestone-e-package-publication-approval-readiness-review-validation-2026-06-21.md)
for source commit `9054f1c` / tree `3f8cb66249826d67ab6030032c7784a2a4ff411b`. Exact approval
decision, signoff, manifest review, assembly evidence, and post-wording gates remain required
while package publication remains blocked and public installation remains blocked.
This prep only identifies tracked trust-loop fixture candidates and guard wiring for internal
continuation; blocked-output alignment keeps the current trust-loop protocol, rehearsal/evidence
matrix, blocker ledger, and matching schemas on the same explicit blockers, while evidence-lane
Expand Down
5 changes: 5 additions & 0 deletions docs/validation/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -341,6 +341,11 @@ recording the exact current-main source candidate and required follow-up evidenc
version, tag, source, manifest, assembly, and wording inputs to source commit `54bf70f` / tree
`5a197bee718e3b31399563340169e9efd4f1317c` while package publication remains blocked and
public installation remains blocked.
- `milestone-e-package-publication-approval-readiness-review-validation-2026-06-21.md` - package
publication approval-readiness review validation for the package publication approval readiness
review; the record summarizes present decision inputs and remaining approval blockers for source
commit `9054f1c` / tree `3f8cb66249826d67ab6030032c7784a2a4ff411b` while package publication
remains blocked and public installation remains blocked.
- `milestone-e-public-facing-readiness-ledger-validation-2026-06-21.md` - public-facing readiness
ledger validation recorded `docs/milestone-e-public-facing-readiness-ledger.json` as a
current-main refresh candidate and package-publication gap-retention artifact; current main
Expand Down
Loading
Loading