Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,7 @@
"package_tag_creation_prep": "docs/validation/milestone-e-package-publication-tag-creation-prep-validation-2026-06-21.md",
"package_decision_bundle_validation": "docs/validation/milestone-e-package-publication-decision-bundle-validation-2026-06-21.md",
"package_pre_approval_gap_ledger": "docs/validation/milestone-e-package-publication-pre-approval-gap-ledger-validation-2026-06-21.md",
"package_decision_input_packet": "docs/validation/milestone-e-package-publication-decision-input-packet-validation-2026-06-21.md",
}
EXPECTED_PUBLICATION_DECISION_INPUTS = {
"decision_status": "not_approved_pending_exact_decision",
Expand Down Expand Up @@ -794,6 +795,10 @@ def test_schema_validation_covers_package_publication_prep(self) -> None:
False,
schema["$defs"]["package_publication_approval_request_packet"]["additionalProperties"],
)
self.assertEqual(
False,
schema["$defs"]["package_publication_decision_input_packet"]["additionalProperties"],
)
self.assertEqual(
False,
schema["$defs"]["package_publication_pre_approval_gap_ledger"]["additionalProperties"],
Expand Down Expand Up @@ -836,6 +841,12 @@ def test_schema_validation_covers_package_publication_prep(self) -> None:
"explicit_exclusions"
]["minItems"],
)
self.assertEqual(
8,
schema["$defs"]["package_publication_decision_input_packet"]["properties"][
"required_before_approval"
]["minItems"],
)
self.assertEqual(
7,
schema["$defs"]["package_publication_pre_approval_gap_ledger"]["properties"][
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,207 @@
#!/usr/bin/env python3
#
# Copyright 2026 The Ethos maintainers
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
#

from __future__ import annotations

import json
import re
import subprocess
import unittest
from pathlib import Path

from makefile_guard import target_block


ROOT = Path(__file__).resolve().parents[2]
PREP = ROOT / "docs/milestone-e-package-publication-approval-prep.json"
RECORD = (
ROOT
/ "docs/validation/"
"milestone-e-package-publication-decision-input-packet-validation-2026-06-21.md"
)
VALIDATION_README = ROOT / "docs/validation/README.md"
PREP_SCOPE = ROOT / "docs/milestone-e-prep-scope.md"
ROADMAP = ROOT / "docs/roadmap.md"
EXECUTION_STATUS = ROOT / "docs/execution-status.md"
CI_WORKFLOW = ROOT / ".github/workflows/ci.yml"

SOURCE_COMMIT = "54bf70f57b8c357ec76059e31d203b80ade7c0e4"
SOURCE_SHORT = "54bf70f"
SOURCE_TREE = "5a197bee718e3b31399563340169e9efd4f1317c"
FORBIDDEN_SCOPE_EXPANSION = [
"public reports are approved",
"public result wording approved",
"release-ready",
"release artifact approved",
"package-ready",
"package publication is approved",
"package publication approved",
"packages are published",
"published packages",
"production-ready",
"production positioning approved",
"benchmark-validated",
"public benchmark pass",
"speed validated",
"fastest",
"launch-ready",
"hosted surface approved",
"hosted demo approved",
"demo-ready",
"performance validated",
"quality validated",
"footprint validated",
"table-quality validated",
"parser-quality validated",
]


def read(path: Path) -> str:
return path.read_text(encoding="utf-8")


def normalized(path: Path) -> str:
return re.sub(r"\s+", " ", read(path))


def load_json(path: Path) -> dict:
return json.loads(path.read_text(encoding="utf-8"))


def git(*args: str) -> str:
return subprocess.check_output(
["git", *args],
cwd=ROOT,
encoding="utf-8",
stderr=subprocess.DEVNULL,
).strip()


class MilestoneEPackagePublicationDecisionInputPacketTests(unittest.TestCase):
def test_packet_is_schema_bound_indexed_and_source_bound(self) -> None:
prep = load_json(PREP)
readme = read(VALIDATION_README)
record = normalized(RECORD)
packet = prep["package_publication_decision_input_packet"]

self.assertIn(RECORD.name, readme)
self.assertIn("package publication decision-input packet validation", re.sub(r"\s+", " ", readme))
self.assertEqual(
"docs/validation/milestone-e-package-publication-decision-input-packet-validation-2026-06-21.md",
prep["follow_up_records"]["package_decision_input_packet"],
)
self.assertEqual("decision_input_packet_recorded_publication_blocked", packet["packet_state"])
self.assertEqual(SOURCE_COMMIT, packet["source_binding"]["candidate_source_commit"])
self.assertEqual(SOURCE_TREE, packet["source_binding"]["candidate_source_tree"])
self.assertIn(f"Validated source HEAD before this record: `{SOURCE_SHORT}`", read(RECORD))
self.assertIn(f"Candidate source commit: `{SOURCE_COMMIT}`", record)
self.assertIn(f"Candidate source tree: `{SOURCE_TREE}`", record)
self.assertEqual(SOURCE_COMMIT, git("rev-parse", SOURCE_SHORT))
self.assertEqual(SOURCE_TREE, git("rev-parse", f"{SOURCE_SHORT}^{{tree}}"))

def test_packet_records_exact_inputs_without_approval(self) -> None:
packet = load_json(PREP)["package_publication_decision_input_packet"]
record = normalized(RECORD)

self.assertEqual(3, len(packet["candidate_crates"]))
self.assertIn("ethos-doc-core mapped from crates/ethos-core", " ".join(packet["candidate_crates"]))
self.assertIn("ethos-verify mapped from crates/ethos-verify", " ".join(packet["candidate_crates"]))
self.assertIn("ethos-pdf mapped from crates/ethos-pdf", " ".join(packet["candidate_crates"]))
self.assertEqual(3, len(packet["candidate_version_map"]))
self.assertEqual(3, len(packet["candidate_package_tag_names"]))
self.assertEqual(4, len(packet["candidate_manifest_activation_diff"]))
self.assertIn("0.1.0; not selected or approved", " ".join(packet["candidate_version_map"]))
self.assertIn("tag is not created", " ".join(packet["candidate_package_tag_names"]))
self.assertIn("current manifest remains unchanged", " ".join(packet["candidate_manifest_activation_diff"]))
self.assertIn("no registry is created and no assembly is activated", packet["registry_backed_assembly_input"])
self.assertIn("public installation remains blocked", packet["candidate_public_installation_wording"])
self.assertIn("this exact decision input packet does not approve package publication", packet["non_approvals"])
self.assertIn("this exact decision input packet does not invite public installation", packet["non_approvals"])
self.assertIn("package publication remains blocked", packet["retained_blockers"])
self.assertIn("public installation remains blocked", packet["retained_blockers"])
for values in (
packet["candidate_crates"],
packet["candidate_version_map"],
packet["candidate_package_tag_names"],
packet["candidate_manifest_activation_diff"],
packet["required_before_approval"],
packet["non_approvals"],
packet["retained_blockers"],
):
for value in values:
self.assertIn(value, record)

def test_candidate_tags_do_not_exist_and_manifests_remain_inactive(self) -> None:
packet = load_json(PREP)["package_publication_decision_input_packet"]
core_manifest = read(ROOT / "crates/ethos-core/Cargo.toml")
verify_manifest = read(ROOT / "crates/ethos-verify/Cargo.toml")
pdf_manifest = read(ROOT / "crates/ethos-pdf/Cargo.toml")

for value in packet["candidate_package_tag_names"]:
tag = value.split(": ", maxsplit=1)[1].split(";", maxsplit=1)[0]
self.assertEqual("", git("tag", "--list", tag))
self.assertIn('name = "ethos-core"', core_manifest)
self.assertIn("publish = false", core_manifest)
self.assertIn('reserved_crates_io_name = "ethos-doc-core"', core_manifest)
self.assertIn('name = "ethos-verify"', verify_manifest)
self.assertIn("publish = false", verify_manifest)
self.assertIn('name = "ethos-pdf"', pdf_manifest)
self.assertIn("publish = false", pdf_manifest)
self.assertNotIn('package = "ethos-doc-core"', verify_manifest)
self.assertNotIn('package = "ethos-doc-core"', pdf_manifest)

def test_docs_reference_decision_input_packet_and_blockers(self) -> None:
for path in (PREP_SCOPE, ROADMAP, EXECUTION_STATUS, VALIDATION_README):
doc = normalized(path)

self.assertIn(RECORD.name, doc, str(path))
self.assertIn("package publication decision input packet", doc.lower(), str(path))
self.assertIn("package publication remains blocked", doc, str(path))
self.assertIn("public installation remains blocked", doc, str(path))

def test_make_and_ci_run_packet_after_resolution_plan(self) -> None:
make_block = target_block("milestone-e-prep")
ci = read(CI_WORKFLOW)
resolution_guard = "test_milestone_e_package_publication_approval_resolution_plan.py"
packet_guard = "test_milestone_e_package_publication_decision_input_packet.py"
public_facing_guard = "test_milestone_e_public_facing_readiness_ledger.py"

for text, prefix in ((make_block, "$(PYTHON) .github/scripts/"), (ci, "python3 .github/scripts/")):
self.assertIn(prefix + packet_guard, text)
self.assertEqual(1, text.count(prefix + packet_guard))
self.assertLess(text.index(prefix + resolution_guard), text.index(prefix + packet_guard))
self.assertLess(text.index(prefix + packet_guard), text.index(prefix + public_facing_guard))

def test_record_avoids_scope_expansion_language_or_private_paths(self) -> None:
lower = normalized(RECORD).lower()
raw = read(RECORD)

for phrase in FORBIDDEN_SCOPE_EXPANSION:
self.assertNotIn(phrase, lower)
self.assertNotIn("/Users/", raw)
self.assertNotIn("/private/tmp", raw)
self.assertNotIn("/private/var", raw)
self.assertNotIn("/var/folders", raw)
self.assertNotIn("saumildiwaker", raw)
self.assertNotIn("Desktop/Stuff", raw)
self.assertNotIn("project/repo/ethos", raw)
self.assertNotIn("docs/.roadmap.md.swp", raw)
self.assertNotIn("web/", raw)


if __name__ == "__main__":
unittest.main()
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,7 @@
"$(PYTHON) .github/scripts/test_milestone_e_package_publication_decision_bundle_validation_record.py",
"$(PYTHON) .github/scripts/test_milestone_e_package_publication_pre_approval_gap_ledger.py",
"$(PYTHON) .github/scripts/test_milestone_e_package_publication_approval_resolution_plan.py",
"$(PYTHON) .github/scripts/test_milestone_e_package_publication_decision_input_packet.py",
"$(PYTHON) .github/scripts/test_milestone_e_public_facing_readiness_ledger.py",
"$(PYTHON) .github/scripts/test_milestone_e_public_beta_current_main_refresh_prep.py",
"$(PYTHON) .github/scripts/test_milestone_e_public_beta_current_main_source_only_approval.py",
Expand Down
1 change: 1 addition & 0 deletions .github/scripts/test_milestone_e_prep_scope.py
Original file line number Diff line number Diff line change
Expand Up @@ -406,6 +406,7 @@ def test_make_target_is_narrow_and_guarded(self) -> None:
"$(PYTHON) .github/scripts/test_milestone_e_package_publication_decision_bundle_validation_record.py",
"$(PYTHON) .github/scripts/test_milestone_e_package_publication_pre_approval_gap_ledger.py",
"$(PYTHON) .github/scripts/test_milestone_e_package_publication_approval_resolution_plan.py",
"$(PYTHON) .github/scripts/test_milestone_e_package_publication_decision_input_packet.py",
"$(PYTHON) .github/scripts/test_milestone_e_public_facing_readiness_ledger.py",
"$(PYTHON) .github/scripts/test_milestone_e_public_beta_current_main_refresh_prep.py",
"$(PYTHON) .github/scripts/test_milestone_e_public_beta_current_main_source_only_approval.py",
Expand Down
4 changes: 4 additions & 0 deletions .github/scripts/test_milestone_e_validation_record_index.py
Original file line number Diff line number Diff line change
Expand Up @@ -262,6 +262,10 @@ class RecordCoverage:
"milestone-e-package-publication-approval-resolution-plan-validation-2026-06-21.md",
"test_milestone_e_package_publication_approval_resolution_plan.py",
),
RecordCoverage(
"milestone-e-package-publication-decision-input-packet-validation-2026-06-21.md",
"test_milestone_e_package_publication_decision_input_packet.py",
),
RecordCoverage(
"milestone-e-public-facing-readiness-ledger-validation-2026-06-21.md",
"test_milestone_e_public_facing_readiness_ledger.py",
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -228,6 +228,8 @@ jobs:
run: python3 .github/scripts/test_milestone_e_package_publication_pre_approval_gap_ledger.py
- name: Milestone E package publication approval resolution-plan tests
run: python3 .github/scripts/test_milestone_e_package_publication_approval_resolution_plan.py
- name: Milestone E package publication decision-input packet tests
run: python3 .github/scripts/test_milestone_e_package_publication_decision_input_packet.py
- name: Milestone E public-facing readiness ledger tests
run: python3 .github/scripts/test_milestone_e_public_facing_readiness_ledger.py
- name: Milestone E public beta current-main refresh prep tests
Expand Down
1 change: 1 addition & 0 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -221,6 +221,7 @@ milestone-e-prep:
$(PYTHON) .github/scripts/test_milestone_e_package_publication_decision_bundle_validation_record.py
$(PYTHON) .github/scripts/test_milestone_e_package_publication_pre_approval_gap_ledger.py
$(PYTHON) .github/scripts/test_milestone_e_package_publication_approval_resolution_plan.py
$(PYTHON) .github/scripts/test_milestone_e_package_publication_decision_input_packet.py
$(PYTHON) .github/scripts/test_milestone_e_public_facing_readiness_ledger.py
$(PYTHON) .github/scripts/test_milestone_e_public_beta_current_main_refresh_prep.py
$(PYTHON) .github/scripts/test_milestone_e_public_beta_current_main_source_only_approval.py
Expand Down
2 changes: 2 additions & 0 deletions docs/execution-status.md
Original file line number Diff line number Diff line change
Expand Up @@ -197,6 +197,8 @@ The current-main source-only public beta approval in `docs/validation/milestone-

The package publication approval resolution plan in `docs/validation/milestone-e-package-publication-approval-resolution-plan-validation-2026-06-21.md` records current source commit `524535a` / tree `0785ffca8423c42e2c4105df7752e290cc88e5c2` as the source state for later exact package-publication decision review. It orders the remaining version, tag, manifest activation, registry-backed assembly, public installation wording, and posture/claims inputs while package publication remains blocked and public installation remains blocked.

The package publication decision input packet in `docs/validation/milestone-e-package-publication-decision-input-packet-validation-2026-06-21.md` records candidate version, tag, source binding, manifest activation, registry-backed assembly, and public installation wording inputs for later review against source commit `54bf70f` / tree `5a197bee718e3b31399563340169e9efd4f1317c`. Package publication remains blocked and public installation remains blocked.

| Work item | Current status | Remaining blocker |
| --- | --- | --- |
| PDFium Phase 1 profile | Landed: pinned profile, V8/XFA-disabled state, platform hashes, runtime library hashes, and provenance are recorded | Phase 2 project-maintained builds still block Public Beta |
Expand Down
Loading
Loading