Repository navigation
Conversation
greg0ire
approved these changes
Oct 18, 2026
Member
|
Thanks @dajiaohuang ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem and change
Several mapping-driver examples in
docs/en/reference/index.rstdo not match the public driver contracts:JSONFileDriveromits theClassMetadataimport and the required parameter/return types.loadMappingFile()decodes the filename instead of reading its contents, and the locator extension is missing its leading dot.ClassMetadatainterface instead of using the mapper's metadata implementation.$phpDriverrather than$staticPHPDriverand describes file loading rather thanUser::loadMetadata()dispatch.Correct the examples and explicitly state that the mapper supplies
$classMetadata. This is one documentation page only; no library API, implementation or dependencies change.Validation
Existing unchanged-base/candidate evidence is reused: PHP 8.3.6 reproduces the original declaration incompatibility; the corrected JSON driver and real FileDriver/locator consumer pass, including filename decoding and extension behavior. Reflection/registry/driver/decorator checks, the real metadata-factory checks and lint of all 36 production PHP files also passed.
Full PHPUnit/PHPStan/PHPCS and documentation generation were not run. The documentation workflow needs PHP 8.4 and a Composer-provided docs builder, absent from the local environment; the exercised library APIs support PHP 8.3. No dependency installation or real ORM/database integration was performed. Normal platform PR checks may run; no CI pass or merge-readiness claim is made.