test(client): improve coverage of DoclingServeClientException - #593
Merged
Conversation
seanJosephFitzpatrick
force-pushed
the
main
branch
from
July 16, 2026 13:59
550c34e to
8236171
Compare
seanJosephFitzpatrick
changed the title
seanJosephFitzpatrick
force-pushed
the
main
branch
from
July 16, 2026 14:31
8236171 to
702f24c
Compare
Signed-off-by: SEAN JOSEPH FITZPATRICK <9217947+seanJosephFitzpatrick@users.noreply.github.com>
…CodeAndNullResponseBody Signed-off-by: SEAN JOSEPH FITZPATRICK <9217947+seanJosephFitzpatrick@users.noreply.github.com>
edeandrea
approved these changes
Jul 16, 2026
Contributor
|
Thanks @seanJosephFitzpatrick ! Once the tests run to success this will merge! |
edeandrea
enabled auto-merge (squash)
July 16, 2026 19:24
:java_duke: JaCoCo coverage report
|
|
||||||||||||||
|
HTML test reports are available as workflow artifacts (zipped HTML). • Download: Artifacts for this run |
|
HTML test reports are available as workflow artifacts (zipped HTML). • Download: Artifacts for this run |
edeandrea
disabled auto-merge
July 16, 2026 20:02
Contributor
|
@all-contributors add @seanJosephFitzpatrick for test |
Contributor
|
I've put up a pull request to add @seanJosephFitzpatrick! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds full unit test coverage for
DoclingServeClientExceptionChanges
New Test Class
DoclingServeClientExceptionTestsDoclingServeClientExceptionCoverage Highlights
DoclingServeClientException— covers all three constructor variants:constructWithCause— verifies message is taken from the cause, cause is retained, and default status code/response body values are set.constructWithNullCause— verifies fallback message"An error occurred"is used when cause isnull.constructWithCauseAndMessage— verifies an explicit message overrides the cause message.constructWithStatusCodeAndResponseBody— verifies message, status code, response body, andnullcause.constructWithStatusCodeAndNullResponseBody— verifies message, status code, andnullresponse body are all propagated correctly.