feat: Custom Metadata and rename arguments#9
Open
lambda-science wants to merge 4 commits intodocling-project:mainfrom
Open
feat: Custom Metadata and rename arguments#9lambda-science wants to merge 4 commits intodocling-project:mainfrom
lambda-science wants to merge 4 commits intodocling-project:mainfrom
Conversation
…ine with other converter. Changed test to be real e2e tests without mock to make sure it works fine.
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🔴 Require two reviewer for test updatesThis rule is failing.When test data is updated, we require two reviewers
🟢 Enforce conventional commitWonderful, this rule succeeded.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
|
Author
|
However with this PR I think we loose the ability to put an URL to file as source |
Lock Transformers before 2.51 because there is a bug huggingface/transformers#37326
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is made to improve the converter with latest Haystack convention. Docling has great potential but this implementation seem's to be dead for months.
pathsargument tosourcesto be in line with other converter.