static: add checksum files for package archives - #495
Merged
Conversation
tianon
reviewed
Aug 17, 2026
| set -x | ||
| cd "${package%/*}" | ||
| sha256sum -c "${package##*/}.sha256" | ||
| tar zxvf $package -C /usr/bin --strip-components=1 |
Contributor
There was a problem hiding this comment.
This one (and all the similar Dockerfiles) need the same ##/* treatment in the tar invocation, right? (since you added cd)
Contributor
|
Is all the duplication expected? This is quite a large PR for what it does 😅 |
Static package builds now emit a sibling .sha256 file for each generated .tgz and .zip archive. Static package verification checks the generated checksum before unpacking artifacts. Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
crazy-max
force-pushed
the
static-checksums
branch
from
August 19, 2026 13:42
a814b99 to
810d7bd
Compare
Member
Author
Yeah it's duplicated in multiple places, will look at improving this as follow-up. Made a simple share checksum file generation script for now. |
Static package builds now use a shared helper to write archive checksum files instead of repeating the same sha256sum block in every package script. Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
crazy-max
marked this pull request as ready for review
August 19, 2026 13:52
crazy-max
requested review from
glours and
ndeloof
and removed request for
a team
August 19, 2026 13:52
tonistiigi
approved these changes
Aug 19, 2026
vvoland
approved these changes
Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
needs #493follow-up #493 (comment)
Static package builds now emit a sibling .sha256 file for each generated .tgz and .zip archive. Static package verification checks the generated checksum before unpacking artifacts.