fix(gateway): guard nil session in mcp-add handler#527
Open
syf2211 wants to merge 1 commit into
Open
Conversation
Fixes docker#442 Add nil checks before accessing req.Session in addServerHandler and getRemoteOAuthServerStatus so mcp-add returns structured errors instead of panicking when session info is unavailable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Guard
req.Sessionbefore callingInitializeParams()andElicit()in themcp-addtool handler so the gateway returns structured errors instead of panicking when session info is unavailable.Fixes #442
Motivation
Some MCP transports/clients invoke
mcp-addwithout populatingreq.Session. The handler dereferencedreq.Sessiondirectly in the missing-config/secrets path and in remote OAuth handling, causing a nil pointer panic instead of a useful response.Changes
req.Session.InitializeParams()when determining client name for missing secrets/config handlinggetRemoteOAuthServerStatus, which already has safe fallbacks)getRemoteOAuthServerStatuswhen session is nilTests
go test ./pkg/gateway/ -run 'TestAddServerHandlerNilSession|TestGetRemoteOAuthServerStatusNilSession' -v -count=1— PASSgo test ./pkg/gateway/ -short -count=1— PASSgo vet ./pkg/gateway/...— PASSmake lint— skipped (requires Docker in this environment)Notes
getRemoteOAuthServerStatuswhen session is nil.