fix(gateway): guard nil Session in mcp-add handler#526
Closed
syf2211 wants to merge 0 commit into
Closed
Conversation
a4f87c8 to
8f422b6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Guard all
req.Sessionaccesses in themcp-addtool handler so a nil session returns a structured error instead of panicking.Motivation
Fixes #442. Some transports/clients invoke gateway tools without populating
req.Session. The handler calledreq.Session.InitializeParams()unguarded when reporting missing secrets/config or during OAuth elicitation, causing a nil pointer dereference.Changes
req.Session != nilguard before reading initialize params when missing secrets/config are reportedgetRemoteOAuthServerStatuswith a nil session checkTestAddServerHandler_NilSessionMissingConfigTests
Notes
auditClientInfoFromSessionalready handles nil sessionsFixes #442