Skip to content

Fix: Pass secret values directly in Docker -e arguments for standalone deployments #338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kimwwk wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −2
Open

Fix: Pass secret values directly in Docker -e arguments for standalone deployments #338

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions pkg/gateway/clientpool.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -329,13 +329,16 @@ func (cp *clientPool) argsAndEnv(serverConfig *catalog.ServerConfig, readOnly *b
}

// Secrets
// Fix: When using Docker over a socket, -e VARNAME looks up the variable
// in the Docker daemon's environment, not the caller's. We must pass the
// value directly as -e VARNAME=value for standalone deployments.
for _, s := range serverConfig.Spec.Secrets {
args = append(args, "-e", s.Env)

secretValue, ok := serverConfig.Secrets[s.Name]
if ok {
args = append(args, "-e", fmt.Sprintf("%s=%s", s.Env, secretValue))
env = append(env, fmt.Sprintf("%s=%s", s.Env, secretValue))
} else {
args = append(args, "-e", s.Env)
log.Logf("Warning: Secret '%s' not found for server '%s', setting %s=<UNKNOWN>", s.Name, serverConfig.Name, s.Env)
env = append(env, fmt.Sprintf("%s=%s", s.Env, "<UNKNOWN>"))
}
Expand Down