Skip to content

deprecate convenience wrappers #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
thaJeztah wants to merge 1 commit into
base: main
Choose a base branch
from
+12 −0
Draft

deprecate convenience wrappers #32

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions handler.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,10 @@ var (

// Handler is a convenience wrapper around [promhttp.Handler] that returns an
// HTTP handler serving metrics from the default Prometheus gatherer.
//
// Deprecated: use [promhttp.Handler] directly.
//
//go:fix inline
func Handler() http.Handler {
return promhttp.Handler()
}
Expand Down
8 changes: 8 additions & 0 deletions register.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,20 @@ import "github.com/prometheus/client_golang/prometheus"

// Register is a convenience wrapper around [prometheus.MustRegister] that
// registers all metrics in n with the default Prometheus registry.
//
// Deprecated: use [prometheus.MustRegister] directly.
//
//go:fix inline
func Register(n *Namespace) {
prometheus.MustRegister(n)
}

// Deregister is a convenience wrapper around [prometheus.Unregister] that
// unregisters all metrics in n from the default Prometheus registry.
//
// Deprecated: use [prometheus.Unregister] directly.
//
//go:fix inline
func Deregister(n *Namespace) {
prometheus.Unregister(n)
}