deprecate Filter type - #74
Merged
Merged
Conversation
Make the filter implementation private and retain Filter as a deprecated type alias for compatibility. Direct construction of Filter was never useful because its zero value is not usable, and NewFilter already returns the Sink interface consumed by callers. Move the concurrency warning to NewFilter, which is now the documented construction path. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
deprecate_filter
branch
from
August 28, 2026 13:30
4667841 to
887c975
Compare
thaJeztah
marked this pull request as ready for review
August 28, 2026 13:30
vvoland
approved these changes
Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
deprecate Filter type
Make the filter implementation private and retain Filter as a deprecated
type alias for compatibility.
Direct construction of Filter was never useful because its zero value is not
usable, and NewFilter already returns the Sink interface consumed by callers.
Move the concurrency warning to NewFilter, which is now the documented
construction path.