chore(deps): github.com/sirupsen/logrus v1.10.2, bump minimum go version to go1.24 - #71
Merged
Merged
Conversation
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Update to the latest logrus to reduce indirect dependencies. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
There was a problem hiding this comment.
Pull request overview
This PR updates the repository’s vendored Go module metadata to use github.com/sirupsen/logrus v1.10.2 and raises the declared minimum Go version to 1.24, along with a small CI matrix adjustment to reflect the newer baseline.
Changes:
- Bump
github.com/sirupsen/logrusfrom v1.9.3 to v1.10.2 (and refresh vendored sums). - Update the module’s declared Go version from 1.13 to 1.24 in
vendor.mod, adding an indirectgolang.org/x/sysrequirement. - Remove the macOS exclusion that existed only due to Go 1.13 limitations.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
vendor.sum |
Refresh vendored dependency checksums consistent with the updated dependency set. |
vendor.mod |
Raise go directive to 1.24 and update direct/indirect requirements (logrus, x/sys). |
.github/workflows/ci.yml |
Remove macOS matrix exclusion previously tied to Go 1.13. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
51
to
54
| go-version: | ||
| - "" # leave empty to use go-version-file (use go.mod); see https://github.com/actions/setup-go/issues/450#issuecomment-3620402646 | ||
| - oldstable | ||
| - stable |
Member
Author
There was a problem hiding this comment.
oldstable is go1.26 now; we deliberately want to test "absolute minimum", and both versions supported by Go itself (latest and latest-1)
vvoland
approved these changes
Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update to the latest logrus to reduce indirect dependencies.