Skip to content

fix(review-pr): remove unsupported schema patterns - #89

Merged
Sayt-0 merged 1 commit into
mainfrom
fix/review-pr-gateway-schema
Aug 19, 2026
Merged

fix(review-pr): remove unsupported schema patterns#89
Sayt-0 merged 1 commit into
mainfrom
fix/review-pr-gateway-schema

Conversation

@Sayt-0

@Sayt-0 Sayt-0 commented Aug 19, 2026

Copy link
Copy Markdown
Member

Summary

  • remove JSON Schema pattern constraints rejected by the Docker models gateway from the drafter and verifier structured outputs
  • preserve minLength: 1 and enforce whitespace-only or placeholder refusal output through fail-closed orchestration checks
  • update regression tests to pin the provider-minimal schemas and semantic refusal handling

Root cause

The models gateway rejected the structured-output schema before sub-agent execution:

  • the original bounded regex failed with Cannot apply a range quantifier
  • a simplified regex still failed with Schema is too complex

This caused transfer_task to fail and reviews to be posted as incomplete.

Validation

Check Result
Exact drafter schema through models gateway pass
Exact verifier schema through models gateway pass
End-to-end review eval pass, 6/6 relevance criteria
Unit tests pass, 933 tests
TypeScript typecheck pass
Biome pass
Build pass
actionlint pass
Fresh-eyes review approved

Changed files

  • review-pr/agents/pr-review.yaml
  • src/pr-review-agent/__tests__/pr-review-yaml.test.ts

@Sayt-0
Sayt-0 enabled auto-merge (squash) August 19, 2026 08:58
@Sayt-0
Sayt-0 merged commit ae22dbb into main Aug 19, 2026
8 checks passed
@Sayt-0
Sayt-0 deleted the fix/review-pr-gateway-schema branch August 19, 2026 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants