Schema tests should be only for latest version#1857
Merged
dgageot merged 1 commit intodocker:mainfrom Feb 26, 2026
Merged
Conversation
![docker-agent[bot]](https://avatars.githubusercontent.com/in/2787757?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Summary
✅ This PR successfully consolidates schema tests to focus only on the latest version. The refactoring is well-executed:
- Removes duplicate schema tests from v4 and v5 packages
- Consolidates
TestJsonSchemaWorksForExamplesinto the main schema test file - Properly updates import paths to reference
latesttypes - Correctly adjusts the schema file path for the new location
Minor observation: There's variable shadowing in TestJsonSchemaWorksForExamples where schemaFile (the local variable containing file contents) shadows the schemaFile constant (the file path). While this is valid Go code and works correctly, consider using a different variable name like schemaBytes or schemaData for clarity.
The changes achieve the stated goal without introducing functional issues.
rumpl
previously approved these changes
Feb 26, 2026
doringeman
reviewed
Feb 26, 2026
Contributor
doringeman
left a comment
doringeman
left a comment
There was a problem hiding this comment.
Thanks! Cherry-picked this on top of #1847 and it fixes task test. 🙌
Signed-off-by: David Gageot <david.gageot@docker.com>
doringeman
approved these changes
Feb 26, 2026
trungutt
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.