Make loading past sessions faster#1854
Merged
dgageot merged 1 commit intodocker:mainfrom Feb 26, 2026
Merged
Conversation
Signed-off-by: David Gageot <david.gageot@docker.com>
![docker-agent[bot]](https://avatars.githubusercontent.com/in/2787757?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Summary
This PR adds a database migration to create an index on session_items(session_id, item_type) to speed up session summary message counts. The change is clean and well-structured.
I verified that this new index serves a different query pattern than the existing idx_session_items_session(session_id, position) index from migration 14. The new index is specifically designed to optimize type-specific queries (e.g., counting messages), while the existing index supports ordered retrieval. Both indexes are justified and serve different access patterns.
No issues found. ✅
rumpl
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.