Conversation
Signed-off-by: David Gageot <david.gageot@docker.com>
rumpl
approved these changes
Feb 25, 2026
![docker-agent[bot]](https://avatars.githubusercontent.com/in/2787757?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Summary
✅ This PR correctly fixes the YAML marshalling issue by updating custom MarshalYAML methods to return (any, error) instead of ([]byte, error). The pattern of returning raw values instead of calling yaml.Marshal() is the correct approach for the yaml.v3 Marshaler interface.
The new test TestParseExamplesAfterMarshalling provides good validation that configs can successfully round-trip through marshalling and unmarshalling, which should prevent the corruption issues mentioned in the PR description.
No issues found in the changed code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes, the yaml configuration marshalling was broken and produced yaml files that couldn't be parsed.
e.g. running
cagent share pushand thencagent share pullwould produce a corrupted yaml.See #1797