allow .github and .gitlab directories in WalkFiles traversal#1833
Open
maxcleme wants to merge 1 commit intodocker:mainfrom
Open
allow .github and .gitlab directories in WalkFiles traversal#1833maxcleme wants to merge 1 commit intodocker:mainfrom
maxcleme wants to merge 1 commit intodocker:mainfrom
Conversation
maxcleme
force-pushed
the
co-allow-github-gitlab-dirs
branch
from
689ac99 to
4d5018b
Compare
![docker-agent[bot]](https://avatars.githubusercontent.com/in/2787757?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Summary
Found one issue in the changed code: the modification to the hidden file/directory filtering logic now causes hidden files (not just directories) to be included in WalkFiles results when they should be skipped.
The original code would skip all hidden items (both files and directories) by returning from the condition early. The new code only applies the skip logic to directories, allowing hidden files like .gitignore, .env, .editorconfig, etc. to pass through and be collected at line 207.
Signed-off-by: maxcleme <maxime.clement@docker.com>
maxcleme
force-pushed
the
co-allow-github-gitlab-dirs
branch
from
4d5018b to
bd35fbe
Compare
Contributor
|
maybe we should guard against .env as a precaution |
Member
Author
|
This |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When working on CI it is super annoying to be not able to use
@with anything inside.github/folder.