Freeze v5 (and a few refactoring)#1810
Merged
dgageot merged 1 commit intodocker:mainfrom Feb 24, 2026
Merged
Conversation
![docker-agent[bot]](https://avatars.githubusercontent.com/in/2787757?s=60&v=4){kind=small}
There was a problem hiding this comment.
Critical Bug Found: Incorrect Package Declarations
This PR introduces a critical compilation error that will prevent the code from building.
All 7 files in the new pkg/config/v5/ package incorrectly declare package latest instead of package v5. This causes a package naming conflict because:
- The files are located in the
pkg/config/v5directory pkg/config/versions.goimportsv5 "github.com/docker/cagent/pkg/config/v5"- It then calls
v5.Register(parsers, &upgraders)expecting av5package - With all files declaring
package latest, the build will fail with "found packages latest (model_config_clone_test.go) and v5 (expected package name) in pkg/config/v5"
Impact: The code will not compile. This must be fixed before merging.
Fix: Change package latest to package v5 in all 7 files in the v5 directory.
Member
|
Should we do this after the skills thing? #1822 |
Member
Author
|
@rumpl OK. Also I think I got it messed up a bit. I'll check tomorrow |
dgageot
force-pushed
the
freeze-v5
branch
2 times, most recently
from
784dbc9 to
63b44da
Compare
Signed-off-by: David Gageot <david.gageot@docker.com>
trungutt
approved these changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.