Skip to content

sigstore: use verifier SAN regex support #1292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
crazy-max wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −11
Open

sigstore: use verifier SAN regex support #1292

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 1 addition & 11 deletions src/sigstore/sigstore.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -392,19 +392,9 @@ export class Sigstore {
const tlogEntries = bundle.verificationMaterial.tlogEntries;
const tlogID = tlogEntries.length > 0 ? tlogEntries[0].logIndex : undefined;

// TODO: remove when subjectAlternativeName check with regex is supported: https://github.com/sigstore/sigstore-js/pull/1556
if (opts?.subjectAlternativeName && opts?.subjectAlternativeName instanceof RegExp) {
const subjectAltName = signingCert.subjectAltName?.replace(/^uri:/i, '');
if (!subjectAltName) {
throw new Error('Signing certificate does not contain subjectAltName');
} else if (!subjectAltName.match(opts.subjectAlternativeName)) {
throw new Error(`Signing certificate subjectAlternativeName "${subjectAltName}" does not match expected pattern`);
}
}

const verifier = new Verifier(trustMaterial);
const signer = verifier.verify(signedEntity, {
subjectAlternativeName: opts?.subjectAlternativeName && typeof opts.subjectAlternativeName === 'string' ? opts.subjectAlternativeName : undefined,
subjectAlternativeName: opts?.subjectAlternativeName,
extensions: opts?.issuer ? {issuer: opts.issuer} : undefined
});
core.debug(`Sigstore.verifyArtifact signer: ${JSON.stringify(signer)}`);
Expand Down
Loading