deps: microStore iterator holds its segment file open - #121
Merged
Conversation
Records the fix now in the microStore retimesh/combined branch: the iterator reopened the segment file for every record, and on LittleFS each open replays the directory's metadata log, which grows with write activity. On the V4's 200-record path store that was 162 ms per record and a 32 s walk that tripped the task watchdog; it is now 32 ms per record and about 6 s. Comment only — the dependency is pinned by branch, so a clean fetch already picks this up. A bench with an existing .pio/libdeps needs pio pkg update to refetch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Records the fix now in the microStore retimesh/combined branch: the iterator reopened the segment file for every record, and on LittleFS each open replays the directory's metadata log, which grows with write activity. On the V4's 200-record path store that was 162 ms per record and a 32 s walk that tripped the task watchdog; it is now 32 ms per record and about 6 s.
Comment only — the dependency is pinned by branch, so a clean fetch already picks this up. A bench with an existing .pio/libdeps needs pio pkg update to refetch.