portal: the split left two unlabelled switches and a warning that could not fire - #117
Merged
Merged
Conversation
…ld not fire Splitting Wi-Fi into an access point and a station changed the keys the API publishes, and the page had two places that still knew the old one. The label table did not, so the new switches rendered under their raw keys — "wifi_ap" and "wifi_sta" — with no word about what either does or which one is worth turning off. They are named now, and the note says the useful thing: the access point is the one to switch off on a battery, because it must beacon and cannot sleep, and it frees only a couple of kilobytes so it is worth doing for the power rather than the memory. The second is the one that matters. Saving the links form used to ask "Turn Wi-Fi off?" before cutting the connection this page is usually being read over. That check tested a key called "wifi", which no longer exists — so it had quietly stopped firing, and the portal would take away its own access without a word. It now asks whenever the save would leave both Wi-Fi links down, which includes turning one off while the other is already off: the case that locks somebody out by changing a single switch, and one the old single-key check could not have expressed even before the split. Also says what the section is. "Local links" is how a phone or laptop reaches this node, not where Reticulum routes — that is the transport form above — and the name invites the other reading. Verified headless against a stub: the guard warns when both links end up down and when the second is already down, and stays quiet when the station survives or nothing changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Splitting Wi-Fi into an access point and a station changed the keys the API publishes, and the page had two places that still knew the old one.
The label table did not, so the new switches rendered under their raw keys — "wifi_ap" and "wifi_sta" — with no word about what either does or which one is worth turning off. They are named now, and the note says the useful thing: the access point is the one to switch off on a battery, because it must beacon and cannot sleep, and it frees only a couple of kilobytes so it is worth doing for the power rather than the memory.
The second is the one that matters. Saving the links form used to ask "Turn Wi-Fi off?" before cutting the connection this page is usually being read over. That check tested a key called "wifi", which no longer exists — so it had quietly stopped firing, and the portal would take away its own access without a word. It now asks whenever the save would leave both Wi-Fi links down, which includes turning one off while the other is already off: the case that locks somebody out by changing a single switch, and one the old single-key check could not have expressed even before the split.
Also says what the section is. "Local links" is how a phone or laptop reaches this node, not where Reticulum routes — that is the transport form above — and the name invites the other reading.
Verified headless against a stub: the guard warns when both links end up down and when the second is already down, and stays quiet when the station survives or nothing changes.