Repository navigation
fix(desktop): reserve panel space and unify bar hover states - #8
Merged
Merged
Conversation
Signed-off-by: Dmitriy Gajewski <dmytrogajewski@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Windows maximized to edges ignored Niri's right strut and extended behind the stack panel. Reserve the panel's 28 logical pixels through layer-shell, releasing them when hidden, and map Waybar first so it retains the full top edge. Waybar restarts now remap the panel after its top surface appears. Shared styling gives every bar module and workspace button a black resting background and the same subtle hover highlight.
Preserve optional ASUS DialPad window rules during configuration apply, declare the Niri 26.04 and jq requirements, and add an isolated desktop geometry check covering startup, maximize, hide/show, fullscreen and repeated Waybar restarts.
Test plan
make lint— formatting and workspace clippy pass with warnings denied.make test— workspace tests pass on this branch based on currentmain.make lint-sparkandmake test-spark.scripts/check-stack-panel-layout.pyagainst this branch's binary at scales 1 and 2; maximized widths were 1252/1280 and 612/640 logical pixels, with full-width Waybar after repeated restarts.#161616on hover under the black theme.Docs
Commit policy
Related