Skip to content

fix(desktop): reserve panel space and unify bar hover states - #8

Merged
dmytrogajewski merged 1 commit into
mainfrom
fix/panel-layout-hover
Nov 1, 2026
Merged

dmytrogajewski merged 1 commit into
mainfrom
fix/panel-layout-hover

Conversation

@dmytrogajewski

Copy link
Copy Markdown
Owner

Summary

Windows maximized to edges ignored Niri's right strut and extended behind the stack panel. Reserve the panel's 28 logical pixels through layer-shell, releasing them when hidden, and map Waybar first so it retains the full top edge. Waybar restarts now remap the panel after its top surface appears. Shared styling gives every bar module and workspace button a black resting background and the same subtle hover highlight.

Preserve optional ASUS DialPad window rules during configuration apply, declare the Niri 26.04 and jq requirements, and add an isolated desktop geometry check covering startup, maximize, hide/show, fullscreen and repeated Waybar restarts.

Test plan

  • make lint — formatting and workspace clippy pass with warnings denied.
  • make test — workspace tests pass on this branch based on current main.
  • make lint-spark and make test-spark.
  • scripts/check-stack-panel-layout.py against this branch's binary at scales 1 and 2; maximized widths were 1252/1280 and 612/640 logical pixels, with full-width Waybar after repeated restarts.
  • GTK 3 computed-color checks across configured modules, status classes and workspace button classes: black at rest, #161616 on hover under the black theme.
  • Live desktop verification: Firefox shrank from 1920 to 1892 logical pixels while Waybar remained 1920 pixels wide.
  • Changed Markdown passes markdownlint and cspell; generated LLM documentation is current.
  • NPU hardware qualification: n/a for these desktop changes.

Docs

  • Updated desktop shell README, bug reports, changelog and generated reference.
  • CLI flags, unit grants and new public Rust APIs: n/a.

Commit policy

  • Commit is signed off under DCO 1.1.
  • Commit subject follows Conventional Commits.

Related

Signed-off-by: Dmitriy Gajewski <dmytrogajewski@gmail.com>
@dmytrogajewski
dmytrogajewski merged commit 800503d into main Nov 1, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants