Repository navigation
Fix syauth applet status after unanswered phone requests - #7
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unanswered phone approvals previously turned the syauth key yellow and labelled it “reconnecting” for ten minutes. The timer later changed the message to “phone reachable” without evidence that the phone had returned.
Keep timeouts and transient transport failures in request history while the daemon-ready key stays normal. Show “approval timed out (phone may be away),” report unknown phone availability, and label the legacy challenge timestamp as “last request.” Daemon-down, unpaired, and confirmed authorization failures retain their warnings. Add renderer regressions and a real-executable CLI test; update the style, troubleshooting guide, incident report, and generated documentation.
The PR also documents adapter-renumbering recovery; its transport repair is in Mewplane/syauth#5. RPM maintenance sets
rustflags_debuginfoto zero because these release packages strip symbols and disable debug packages. This resolves the Fedora 45 disk-quota failure while retaining optimization and hardening flags. The RPM check phase compiles a retained Rust fixture and checks its symbol and ELF sections to prevent unused DWARF data from returning.Validation: all applicable GitHub checks pass on
b2db770, including Fedora 43/44/45 RPM builds, Rust documentation, site generation, spelling, Markdown, links, and Vale. The clean-worktree suite passed 1,659 tests with zero failures and 12 ignored;make lintpassed. The new compiler-output regression failed with the original RPM flags and passes inside the repaired Fedora package builds. The Fedora 45 log confirms-Cdebuginfo=0, a passing regression, and successful RPM creation.CI matrix: https://github.com/dmytrogajewski/sy/actions/runs/41260872613
The repaired applet RPM is installed on the host. Package verification passes, and its live output stayed normal with a nine-second-old timeout. The presence daemon was not restarted. That deployment predates the packaging-only debug-data correction.