Open
Conversation
Member
|
I don't think individual test timing has any meaning in DBS unit tests. This individual test mainly for cover different use cases. Each API speed is more depending on the DB load and the server load at the time it is executed. However, the overall speed does reflect some underline problems. Adding individual timing may mislead the testers. So I will not commit the PR. |
Contributor
Author
|
Yuyi, it is up to you, I only put PR to make it clear how I get those timing numbers. It also helped me to understand the difference in APIs. Will you use it or not it is totally your decision, but I felt it would be better documented (even as closed issue). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.