fix(server): remove lingering stdin listeners in _writeWithBackpressure#172
Open
kainstar wants to merge 1 commit into
Open
fix(server): remove lingering stdin listeners in _writeWithBackpressure#172kainstar wants to merge 1 commit into
kainstar wants to merge 1 commit into
Conversation
When `drain` fires first, the `once('error')` and `once('close')`
handlers were never removed from stdin, causing them to accumulate
across multiple `compareBuffers` calls and triggering Node.js
MaxListenersExceededWarning on the stdin Socket.
Fix by converting anonymous callbacks to named functions so that each
handler can explicitly remove the other two when it fires.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When
_writeWithBackpressureneeds to wait fordrain, it registers threeoncelisteners onstdin:When
drainfires first, only the drain handler is auto-removed (byonce). Theerrorandclosehandlers are never removed — they linger on the stdinSocketindefinitely.All writes to
ODiffServerare serialized bywriteLock, so listeners never pile up concurrently. Instead, they accumulate sequentially: every write that encounters backpressure and resolves viadrainleaves behind one orphanederrorlistener and one orphanedcloselistener. After 11 such writes over the server's lifetime, the warning fires:Fix
Convert the anonymous callbacks to named functions so each handler can explicitly remove the other two when it settles:
This ensures stdin's listener count stays bounded regardless of how many comparisons are run.