chore(deps): bump git2 to 0.21.0 to clear RUSTSEC-2026-0183/0184 (#733) - #734
Merged
Merged
Conversation
git2 0.20.4 carries two informational=unsound advisories that surface in downstream cargo-audit/cargo-deny runs. fff does not call the affected APIs (Remote::list, Blame::blame_buffer), but bumping clears the noise for consumers. 0.21.0 changes StatusEntry::path() to return Result<&str, git2::Error> instead of Option<&str>; adjust the two callers in fff-core. Closes #733
dmtrKovalenko
approved these changes
Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #733
Root cause
Workspace pin
git2 = "0.20.2"inCargo.toml:29resolves to 0.20.4, which carries twoinformational = "unsound"advisories (RUSTSEC-2026-0183, RUSTSEC-2026-0184). fff does not call the affected APIs (Remote::list,Blame::blame_buffer) — usage is limited toRepository,StatusOptions,Status*,Version::get— but every downstream consumer offff-search/fff-grep/fff-query-parsersees the advisories incargo audit/cargo denyand must add a suppression.Fix
Bump workspace
git2to0.21.0. Feature set unchanged (default-features = false,vendored-libgit2). 0.21 changesStatusEntry::path()fromOption<&str>toResult<&str, git2::Error>; adjust the two callers incrates/fff-core/src/git.rs:65andcrates/fff-core/tests/fuzz_git_watcher_stress.rsaccordingly (drop non-UTF-8 paths, same behavior as before).Steps to reproduce
Confirm the advisories surface on pre-fix
origin/main:cargo install cargo-audit --locked git fetch origin main && git checkout origin/main cargo audit --file Cargo.lockExpected: two warnings
How verified
Diff size: 4 files, +8/-9.
Automated triage via Gustav. Honk-Honk 🪿