fix(pi-fff): pin SDK dependencies during publish - #712
Merged
dmtrKovalenko merged 1 commit intoJul 30, 2026
Merged
dmtrKovalenko merged 1 commit into
dmtrKovalenko merged 1 commit into
Conversation
dmtrKovalenko
approved these changes
Jul 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
@ff-labs/pi-fffis published with wildcard dependencies on@ff-labs/fff-nodeand@ff-labs/fff-bun. An existing npm lockfile can therefore retain an older SDK and native binary afterpi-fffitself is updated, leaving Pi exposed to native bugs fixed in the matching release.Extend the existing
set-npm-versionrelease step to set both SDK dependencies to the release version. Publishedpi-fffpackages will then require the matching Node and Bun SDK/native release instead of accepting any version.Fixes #710.
Steps to Reproduce Bug and Validate Solution
Reproduce
@ff-labs/fff-nodethrough@ff-labs/pi-fffand retain the npm lockfile.@ff-labs/pi-fffto0.10.1."@ff-labs/fff-node": "*".A real installation retained
fff-nodeandfff-bin-darwin-arm640.9.3 whilepi-fffand the Bun SDK were 0.10.1. Two Pi processes subsequently blocked infff_live_grep/parking_lot::RawRwLocknative frames.Validate
make set-npm-versionwithVERSION=9.8.7against temporary copies ofpi-fff,fff-node, andfff-bunmanifests.pi-fffSDK dependencies become9.8.7, platform optional dependencies still become9.8.7, and unrelatedfff-nodedependencies remain unchanged.bun test packages/pi-fff/test.PR Checklist
Does This Introduce a Breaking Change?
Testing
make set-npm-versionassertions;bun test packages/pi-fff/test;git diff --checkpi-fffdirect SDK dependency synchronization, existing platform optional-dependency synchronization, and preservation of unrelated dependenciesOther Information or Known Dependencies
The full npm publication workflow was not run locally because it requires release credentials and built platform artifacts. Lint was not run because the change only modifies the Makefile's existing inline manifest-rewrite script.