Skip to content

fix(pi-fff): preserve path/exclude in fuzzy grep fallback (#697) #699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dmtrKovalenko merged 2 commits into from
Jul 23, 2026
Merged

fix(pi-fff): preserve path/exclude in fuzzy grep fallback (#697) #699

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
645ef62
fix(pi-fff): preserve path and exclude constraints in fuzzy grep fall…
gustav-fff Jul 21, 2026
d500af2
fix(pi-fff): drop path constraint in fuzzy fallback only for file paths
gustav-fff Jul 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion packages/pi-fff/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -724,7 +724,15 @@ export default function fffExtension(pi: ExtensionAPI) {

// automatic fuzzy fallback allows to broad the queries and find different cases
if (result.items.length === 0 && !params.cursor && mode !== "regex") {
const fuzzy = picker.grep(pattern, {
// When the caller pinned a specific file (path has an extension), the
// fuzzy fallback broadens across the whole picker — the file may just
// be misnamed. For directory constraints (or no path), we keep the
// constrained query so the fallback does not leak matches from
// excluded / out-of-scope directories.
const lastSeg = params.path?.split(/[\\/]/).pop() ?? "";
const pathTargetsFile = /\.[a-zA-Z][a-zA-Z0-9]{0,9}$/.test(lastSeg);
const fuzzyQuery = pathTargetsFile ? pattern : query;
const fuzzy = picker.grep(fuzzyQuery, {
mode: "fuzzy",
smartCase,
maxMatchesPerFile: Math.min(effectiveLimit, 50),
Expand Down
Loading