feat(c): add stable FffResult accessors - #681
Merged
dmtrKovalenko merged 1 commit intoJul 16, 2026
Merged
Conversation
dmtrKovalenko
approved these changes
Jul 16, 2026
abhijit-s
pushed a commit
to abhijit-s/fff
that referenced
this pull request
Jul 17, 2026
Brings in upstream 0.10.0 batch: SDK file-watcher exposure (dmtrKovalenko#674), stable FffResult C accessors (dmtrKovalenko#681), pi-fff non-cwd + isomorphic SDK fixes (dmtrKovalenko#622, dmtrKovalenko#669), picker_ui fuzzy-match highlight (dmtrKovalenko#673), README FAQ (dmtrKovalenko#680), vimdoc regen (dmtrKovalenko#683). Conflict resolution: - All crate Cargo.toml + workspace: take ours (0.17.0). Upstream's 0.10.0 is its own independent release line; the fork stays on 0.17.0. fff-mcp keeps its daemon-only deps (fff-ipc/dirs/libc). - fff-core/src/lib.rs: keep BOTH the fork's content_staleness_recheck test module and upstream's new pub watch module (non-overlapping). - install-mcp.sh: keep ours — the fork installs from HEAD/source and points at abhijit-s, so upstream's v0.10.0 release-pinning + SHAs do not apply. - Cargo.lock: ours (no reconciliation needed on build). Verified: build-daemon green; fff-search suite incl. upstream's new watch:: tests + the fork's 4 content_staleness_recheck regressions; daemon crate tests — all 0 failures.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FffResultpayload fieldsMotivation
Consumers should not need to depend on the in-memory layout of
FffResult. Named accessors make the ABI consumption explicit and let clients such asfff.elavoid raw offsets.Validation
cargo fmt --check -p fff-ccargo test -p fff-c --libnm -D