feat: Significantly faster per-platform optimized file walking & gitignore matcher - #645
Merged
Merged
Conversation
; Conflicts: ; crates/fff-core/src/file_picker.rs ; crates/fff-core/tests/scan_correctness_contract.rs
dmtrKovalenko
force-pushed
the
feat/zlob-walker
branch
7 times, most recently
from
July 2, 2026 02:29
8031ffc to
ec84820
Compare
dmtrKovalenko
force-pushed
the
feat/zlob-walker
branch
from
July 2, 2026 17:08
ec84820 to
6ce9f24
Compare
The zlob walker emits '/'-separated relative paths on every platform. Instead of converting every walked path to native '\' on Windows, make '/' the canonical internal separator throughout the index and convert native inputs to '/' on the (fewer) inbound lookup paths. Native separators are re-applied only at OS/state boundaries: - write_absolute_path nativizes for git-cache keys, frecency, Win32 APIs - frecency keys additionally canonicalize on Windows (dunce), with a raw-string fallback so watcher deletes never drop the op Removes several scattered Windows compensations (score.rs fuzzy folds, constraints.rs collect fold) now that stored paths are already '/'. relative_path emitted to Lua is now '/' on all platforms.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.