fix: avoid clobbering existing lists#74
Merged
Merged
Conversation
62619e0 to
97b8637
Compare
dmmulroy
approved these changes
Jan 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've found a small issue with the quickfix list integration.
Setting the replace flag when sending the TSC results into the quickfix list truncates existing results.
That's a problem because the quickfix list keeps a history of all the lists generated during the session, and you can navigate the history with
:colderand:cnewer. Which means that populating the list from tsc.nvim hijacks whatever list spot we were displaying.For example, imagine you have the lists in
:chistoryThen you navigate back to see the second list with
:colder.Then you use TSC and send the results to the list:
Now I've lost
grug-far results 2.I'm updating the quickfix action to replace the list only if the existing list was created by TSC. That way we can keep the exiting flow that shows the latest state regarding TSC, and avoid destroying unrelated lists.