Skip to content

Return GP predictions as column vectors#55

Draft
Mirochill wants to merge 1 commit into
dme65:masterfrom
Mirochill:fix-48-gp-predict-column
Draft

Return GP predictions as column vectors#55
Mirochill wants to merge 1 commit into
dme65:masterfrom
Mirochill:fix-48-gp-predict-column

Conversation

@Mirochill

Copy link
Copy Markdown

Fixes #48

Summary:

  • return GPRegressor.predict() results as (num_pts, 1) column vectors, matching the documented shape and predict_std()
  • add shape assertions for GP predictions and standard deviations in the existing surrogate test

Validation:

  • git diff --check
  • git diff --cached --check
  • git show --check --oneline HEAD -- pySOT/surrogate/gp.py tests/test_surrogates.py
  • git show --stat --oneline --summary HEAD
  • Static inspection of pySOT/surrogate/gp.py, pySOT/auxiliary_problems/ei_merit.py, and tests/test_surrogates.py
  • Not run locally

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

In gp.py, predict() returns incorrectly-sized array, causing IndexError exception in ei_merit().

1 participant