ci: add fast build-free lint gate for PRs and pushes to main - #8
Merged
Conversation
The only existing workflow (build-libraries.yml) is manual-dispatch-only, so PRs and merges got zero automated checks. Add a CI workflow that lints the file types that actually change here and have broken the pipeline before: - shellcheck on tracked *.sh - actionlint on .github/workflows (also shellchecks run: blocks) - PSScriptAnalyzer on *.ps1 (fails on Error-level findings) Runs in ~1-2 min on ubuntu, read-only token, cancels superseded runs. The heavy ~90-min toolchain build stays on manual dispatch by design. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
First run of the new gate flagged 3 shellcheck warnings in tools/build-library-bundle.sh: SC2209 (quote the pkg_for[] string values) and two SC2154 false positives (source[]/sha256sums[] come from the sourced PSPBUILD). Quote the package-name map and annotate the two PKGBUILD-derived arrays with disable directives. Split ci.yml into three independent jobs (shellcheck / actionlint / powershell) so each linter reports even when another fails, instead of fail-fast hiding actionlint behind a shellcheck failure. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
The explanatory comment above the SC2154 disable started a line with '# shellcheck can't see...', which shellcheck parsed as a malformed directive (SC1072/SC1073). Reword so no comment line begins with the directive token.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add a fast, build-free CI gate that runs on every
pull_requestand everypushtomain.Until now the only workflow (
build-libraries.yml) was manual-dispatch-only, so PRs and merges received zero automated checks (confirmed by an audit of all 10 historical runs — every one was a manual dispatch). This adds real merge-gating without the ~90-min toolchain build.Jobs (~1-2 min total, ubuntu, read-only token)
actionlinton.github/workflows+shellcheckon tracked*.shif:, expressions, deprecated runners); with shellcheck on PATH it also lintsrun:blocksPSScriptAnalyzeron*.ps1bootstrap-windows.ps1on Error-level findingsactionlintpinned tov1.7.12, installed viago install(checksum-verified through the Go proxy — nocurl \| bash)concurrencycancels superseded runs; the heavy toolchain build stays on manual dispatch by designThis PR is its own first test — the gate runs against itself here. Merging is contingent on it going green.
🤖 Generated with Claude Code