Initial work on migrating some of the rules in initnull's Tachyon#1
Open
DrDub wants to merge 1 commit intodma:developfrom
Open
Initial work on migrating some of the rules in initnull's Tachyon#1DrDub wants to merge 1 commit intodma:developfrom
DrDub wants to merge 1 commit intodma:developfrom
Conversation
… Discovery system to Vega. Up to my knowledge and understanding of the code, this module should enqueue extra checks, however it is not, it seems ctx.submitRequest calls are being ignored It is unclear whether a module license is important regarding EPL vs. GPL. In the worse case we can ask initnull's to re-license these files.
Author
|
The concept of using robots.txt is also very appealing. Which class can I use to get me started? Dir404Tests? |
Owner
|
Hey, cool, I'm just going to take a look at what you guys are doing here. Nice to see you hacking on Vega. |
Author
|
ping |
Author
|
Ping. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Up to my knowledge and understanding of the code, this module should enqueue
extra checks, however it is not, it seems ctx.submitRequest calls are being ignored
It is unclear whether a module license is important regarding EPL vs. GPL. In the
worse case we can ask initnull's to re-license these files.
(If you have a better idea about how to do this, just push back and send me in the
right direction.)