Add --no-x flag counterpart for bool query params - #13
Open
dm1tryG wants to merge 1 commit into
Open
Conversation
Typer does not auto-generate a --no-x flag when the option name is given explicitly as a string, so a bool query param like --done had no way to send an explicit false. Now bool params render as "--name/--no-name" flag pairs so both true and false are reachable from the CLI. Closes #7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
typer.Option(default, "--name/--no-name", ...)instead of a single--nameflag, so callers can explicitly passfalse(previously only--nameexisted and there was no way to set false explicitly).Test plan
uv run pytest— 32 passed--no-donewithout a "No such option" error--done/--no-donewithNonedefault correctly yieldsTrue/False/NoneCloses #7