Advertise the adjunct queue; drop dead Batch links (closes #899) - #1238
Draft
tomcrane wants to merge 1 commit into
Draft
Advertise the adjunct queue; drop dead Batch links (closes #899)#1238tomcrane wants to merge 1 commit into
tomcrane wants to merge 1 commit into
Conversation
Session-0 ruling (hygiene sprint, 2026-08-06), the inverse direction of the rule applied in the unreachable-links PR: - Customer gains the adjunctQueue link - GET/POST routes have existed since the adjunct-queue API landed, but the model never advertised them - AdjunctBatch reinstates its currentAdjuncts and adjuncts links; the stale "not implemented yet" TODO predated the routes. currentAdjuncts is SetManually because the route is /current, not /currentAdjuncts - the converter sets it explicitly - Batch drops the completedImages and errorImages links (and their vocab operations): no such routes exist - these are the named examples in #899 - and batches/{id}/images already supports the full asset-query syntax BREAKING (minor): Batch responses no longer contain the completedImages and errorImages links; both only ever led to 404s. Closes #899. Refs #1166. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
The inverse direction of #1237's rule (hygiene-sprint session 0, 2026-08-06: the model advertises exactly the reachable surface) — three places where Hydra models under- or mis-advertise what actually exists:
Customergains theadjunctQueuelink.GET/POST /customers/{id}/adjunctQueuehave existed since the adjunct-queue API landed (Add additional query endpoints for adjunct batches #1228), but the model never advertised them, so hypermedia navigation couldn't find the adjunct queue. Includes vocab operations (newCustomerAdjunctQueueClass.GetSpecialAdjunctQueueOperations(), mirroring thequeuelink's pattern).AdjunctBatchreinstates itscurrentAdjunctsandadjunctslinks. They were commented out with a "not implemented yet" TODO that predates the routes —batches/{id}/currentandbatches/{id}/adjunctsboth exist.currentAdjunctsisSetManuallybecause auto-generation would emit{@id}/currentAdjuncts, which doesn't match the/currentroute; the converter sets it explicitly.Batchdrops thecompletedImagesanderrorImageslinks (and their vocab operations). No such routes exist — these are the named examples in Invalid hypermedia links in responses #899 — andbatches/{id}/imagesalready supports the full asset-query syntax for filtering.Note
Behaviour change for release notes:
Batchresponses no longer contain thecompletedImages/errorImageslinks (both only ever led to 404s).Customerresponses gainadjunctQueue;AdjunctBatchresponses gaincurrentAdjunctsandadjuncts.With the dead-link removals in #1237, this should complete #899 ("Invalid hypermedia links in responses") — its two named examples are resolved here. Closes #899. Refs #1166.
Also observed, not changed here (flagged for the register):
AdjunctBatch's[HydraClass]attribute referencestypeof(AdjunctBatch)(itself) rather than aClass-derived vocab type — the same defect class as theQueueSummaryfix in #1235.Merge-order note: #1236 and #1237 also touch
Customer.csin nearby regions; whichever merges last may see a trivial adjacent-line conflict.Builds clean; DLCS.Hydra.Tests 19/19; AdjunctBatchConverter unit tests 4/4. The docs-side twin (removing the two phantom links from batch.mdx's example) is in dlcs/public-docs#9.
🤖 Generated with Claude Code