Skip to content

Stop advertising Hydra links to unreachable subsystems #1237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
tomcrane wants to merge 1 commit into
base: develop
Choose a base branch
from
+0 −63
Draft

Stop advertising Hydra links to unreachable subsystems #1237

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 0 additions & 25 deletions src/protagonist/DLCS.HydraModel/Customer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,25 +77,6 @@ public Customer(string baseUrl, int customerId, string name, string displayName)
[JsonProperty(Order = 17, PropertyName = "defaultDeliveryChannels")]
public string? DefaultDeliveryChannels { get; set; }

[HydraLink(Description = "Collection of IIIF Authentication services available for use with your images. The images are" +
" associated with the auth services via Roles. An AuthService is a means of acquiring a role.",
Range = Names.Hydra.Collection, ReadOnly = true, WriteOnly = false)]
[JsonProperty(Order = 18, PropertyName = "authServices")]
public string? AuthServices { get; set; }

[HydraLink(Description = "Collection of external services which provide aq login page (typically) and an endpoint " +
" from which the DLCS acquires the user's named roles. This enables integration with external auth mechanisms.",
Range = Names.Hydra.Collection, ReadOnly = true, WriteOnly = false)]
[JsonProperty(Order = 19, PropertyName = "roleProviders")]
public string? RoleProviders { get; set; }

[HydraLink(Description = "Collection of the available roles you can assign to your images. In order for a user to see an image, the " +
"user must have the role associated with the image, or one of them. Users interact with an AuthService to " +
"acquire a role or roles.",
Range = Names.Hydra.Collection, ReadOnly = true, WriteOnly = false)]
[JsonProperty(Order = 20, PropertyName = "roles")]
public string? Roles { get; set; }

[HydraLink(Description = "The Customer's view on the DLCS ingest queue. As well as allowing you to query the status of batches you " +
"have registered, you can POST new batches to the queue.",
Range = "vocab:Queue", ReadOnly = true, WriteOnly = false)]
Expand Down Expand Up @@ -172,12 +153,6 @@ public override void DefineOperations()
GetHydraLinkProperty("originStrategies").SupportedOperations = CommonOperations
.GetStandardCollectionOperations(operationId + "originStrategy_", "Origin Strategy", "vocab:OriginStrategy");

GetHydraLinkProperty("authServices").SupportedOperations = CommonOperations
.GetStandardCollectionOperations(operationId + "authService_", "Auth Service", "vocab:AuthService");

GetHydraLinkProperty("roles").SupportedOperations = CommonOperations
.GetStandardCollectionOperations(operationId + "role_", "Role", "vocab:Role");

GetHydraLinkProperty("queue").SupportedOperations = QueueClass.GetSpecialQueueOperations();

GetHydraLinkProperty("spaces").SupportedOperations = CommonOperations
Expand Down
38 changes: 0 additions & 38 deletions src/protagonist/DLCS.HydraModel/EntryPoint.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,20 +34,6 @@ public EntryPoint(string baseUrl)

public string? PortalRoles { get; set; }

[HydraLink(Description = "List of available optimisation policies the DLCS uses to process your image to provide a IIIF endpoint. " +
"We keep a record of the policy used to allow a different policy (e.g., better quality) to be used later.",
Range = Names.Hydra.Collection, ReadOnly = true, WriteOnly = false)]
[JsonProperty(Order = 14, PropertyName = "imageOptimisationPolicies")]

public string? ImageOptimisationPolicies { get; set; }


[HydraLink(Description = "List of all the different roles available to portal users - i.e., the small number of people who log into the portal." +
" These are not the same as the roles end users acquire for accessing protected image services.",
Range = Names.Hydra.Collection, ReadOnly = true, WriteOnly = false)]
[JsonProperty(Order = 15, PropertyName = "thumbnailPolicies")]
public string? ThumbnailPolicies { get; set; }

[HydraLink(Description = "Available storage policies that can be associated with a Customer or a Space. They determine the " +
"number of images and storage capacity permitted to the Customer or Space.",
Range = Names.Hydra.Collection, ReadOnly = true, WriteOnly = false)]
Expand Down Expand Up @@ -112,30 +98,6 @@ public override void DefineOperations()
}
};

var imageOptimisationPolicies = GetHydraLinkProperty("imageOptimisationPolicies");
imageOptimisationPolicies.SupportedOperations = new[]
{
new Operation
{
Id = "_:imageOptimisationPolicy_collection_retrieve",
Method = "GET",
Label = "Retrieves the policies the DLCS can use or has used in the past to optimise your origin image for IIIF delivery",
Returns = Names.Hydra.Collection
}
};

var thumbnailPolicies = GetHydraLinkProperty("thumbnailPolicies");
thumbnailPolicies.SupportedOperations = new[]
{
new Operation
{
Id = "_:thumbnailPolicy_collection_retrieve",
Method = "GET",
Label = "Retrieves available thumbnail polices - a record of the thumbnails created for an image.",
Returns = Names.Hydra.Collection
}
};

var storagePolicies = GetHydraLinkProperty("storagePolicies");
storagePolicies.SupportedOperations = new[]
{
Expand Down
Loading