Disallow slugs from having slashes or FQDN's in them - #645
Merged
Conversation
JackLewis-digirati
marked this pull request as ready for review
August 4, 2026 09:48
donaldgray
reviewed
Aug 4, 2026
donaldgray
left a comment
donaldgray
left a comment
Member
There was a problem hiding this comment.
Service AppSetting Required? Description Default API ApiSettings:ProhibitedSlugCharactersY Prohibited characters in the slug ["/"]
I think "Required?" should be N for this. It's not required as it has a default, and (untested) it looks like if you set it to an empty array it'd just let through every character.
JackLewis-digirati
force-pushed
the
fix/slashesInSlugs
branch
from
August 5, 2026 15:33
eabc7f0 to
66946c7
Compare
Collaborator
Author
|
Changed Required to be N following discussion |
donaldgray
approved these changes
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Resolves #571
Makes it so slugs aren't allowed to have FQDN's or forward slashes. This is also extendable, due to adding a setting controlling characters that are disallowed from use in slugs.
Configuration Changes
Note
This PR introduces configuration changes.
ApiSettings:ProhibitedSlugCharacters["/"]