Support adding headers, scoped by url + customer - #94
Open
donaldgray wants to merge 1 commit into
Open
Conversation
This is similar to CustomerOriginStrategy in Protagonist. It allows custom headers to be specified per customer and origin URL. Note that setuptools version pining in docker image is temporary, follow up PR will update to django-q2 and this can go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is similar to CustomerOriginStrategy in Protagonist. It allows custom headers to be specified per customer and origin URL.
Note
Setuptools version pinning in docker image is temporary, follow up PR #93 updates to django-q2 and this can go.
Rather than add a table (and model/migration etc) I've kept it fairly lightweight. The entire JSON block is specified as an envvar, will be in format:
{ "2": { // customer "^https://customer-url.*": { // regex "addHeader": { // type of operation "X-Api-Key": "abc12345" // add "X-Api-Key:abc12345 to matches } } } }This is obviously pretty limited but meets the requirements, if these expand we can look to add something more robust. My thinking is that the behaviour in repo is pretty much unchanged in 3/4 years so no need to add exhaustive handling at this stage.