dtoh: Emit _d_dynamicArray template which represents slices#11882
dtoh: Emit _d_dynamicArray template which represents slices#11882dlang-bot merged 2 commits intodlang:masterfrom
Conversation
|
Thanks for your pull request and interest in making D better, @MoonlightSentinel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + dmd#11882" |
c8ae8c4 to
fa4d021
Compare
|
See also https://github.com/thewilsonator/interop/blob/master/c%2B%2B/dslice.h @jacob-carlborg which were the PRs we tried to add this in? |
That would have been my next thought. I know we use |
|
To make it clear, dtoh only deals with fields, not parameters. |
Fine by me |
fa4d021 to
d591c37
Compare
|
Made a few adjustments:
|
77e39de to
c200b5d
Compare
Since slices are a central building block of D, they should also be easily accessible from C++.
... s.t. it can be used like a normal array (+ bounds checking)
c200b5d to
3a426c8
Compare
Since slices are a central building block of D, they should also be easily accessible from C++.
CC @ibuclaw
Questions:
_d_dynamicArraydefine addtional functions, e.g.operator[]?_d_dynamicArraybe hidden behind an#if !defined(...)to allow custom definitions?