Skip to content

dmd.dtoh: export genCppHdrFiles to C++#10821

Merged
dlang-bot merged 3 commits intodlang:masterfrom
ibuclaw:dtohcpp
Feb 23, 2020
Merged

dmd.dtoh: export genCppHdrFiles to C++#10821
dlang-bot merged 3 commits intodlang:masterfrom
ibuclaw:dtohcpp

Conversation

@ibuclaw
Copy link
Copy Markdown
Member

@ibuclaw ibuclaw commented Feb 22, 2020

Follow-up to #10801.

This allows genCppHdrFiles to be called from gdc.

@ibuclaw ibuclaw added the Compiler:GDC Gnu D Compiler label Feb 22, 2020
@dlang-bot
Copy link
Copy Markdown
Contributor

Thanks for your pull request, @ibuclaw!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + dmd#10821"

Comment thread src/dmd/dtoh.d Outdated
@MoonlightSentinel
Copy link
Copy Markdown
Contributor

Most of these changes are irrelevant to the C++ interface...

Also why move the ‚pragma once‘ After the comment?

@ibuclaw
Copy link
Copy Markdown
Member Author

ibuclaw commented Feb 22, 2020

Most of these changes are irrelevant to the C++ interface...

Rationale of these three commits are:

  1. FTBFS: dmd/mars.d doesn't exist in gdc source tree
  2. FTBFS: Couldn't call genCppHdrFiles from C++
  3. Allow for gdc to advertise itself as the generator.

Also why move the ‚pragma once‘ After the comment?

Usually (least in every other tool I've used and/or written) the generated file notice is on the first line. I found it surprising that it wasn't.

@MoonlightSentinel
Copy link
Copy Markdown
Contributor

Rationale of these three commits are:

Thanks for the explanation. These changes seem reasonable but the PR title is a bit misleading.

Usually (least in every other tool I've used and/or written) the generated file notice is on the first line. I found it surprising that it wasn't.

Okay, improving user experience is always nice.

@dlang-bot dlang-bot merged commit f15150f into dlang:master Feb 23, 2020
@ibuclaw ibuclaw deleted the dtohcpp branch February 23, 2020 08:11
@ibuclaw ibuclaw added the Feature:dtoh C++ header generation label Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Compiler:GDC Gnu D Compiler Feature:dtoh C++ header generation Merge:auto-merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants