Skip to content

Dev#47

Open
dkcodec wants to merge 75 commits into
mainfrom
dev
Open

Dev#47
dkcodec wants to merge 75 commits into
mainfrom
dev

Conversation

@dkcodec
Copy link
Copy Markdown
Owner

@dkcodec dkcodec commented Apr 7, 2026

No description provided.

@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 7, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
app-bagsy Ready Ready Preview, Comment May 16, 2026 5:18am

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 836816ceb9

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +176 to +177
const newHours = mapScheduleSlotsToWorkingHours(slots);
if (!newHours) return; // Нет данных — оставляем текущие
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Reset calendar hours when fetched schedule is empty

When loadSchedule gets a valid response with zero work slots, mapScheduleSlotsToWorkingHours returns null and this early return skips all state updates. That leaves workingHours from the previously selected employee/location visible, so users can see and interact with stale availability after switching to someone with an empty schedule. Instead of returning, this path should explicitly clear/update workingHours (and range metadata) for the requested interval.

Useful? React with 👍 / 👎.

Comment on lines 221 to 224
partialize: state => ({
badgeVariant: state.badgeVariant,
locationId: state.locationId,
}),
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Do not persist selected location without user validation

Persisting locationId in local storage can leak location context across auth transitions, while downstream code prefers stored selection over currentUser.location_id (for example in calendar-context/index.tsx). If a session expires or a different account logs in without explicit logout cleanup, the app can continue querying the old location and show unauthorized/incorrect data. This value should be recomputed from the current user (or validated) on startup rather than blindly restored.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant