Repository navigation
Fix CI: replace removed next lint with eslint - #1
Merged
Merged
Conversation
`next lint` was removed in Next.js 16, so CI failed before linting anything. Switching to `npm run lint` surfaced 246 errors that were never enforced: - 238 no-explicit-any: downgraded to warn (tighten as types are added) - window.location.href assignments -> window.location.assign (same behavior) - prefer-const and no-empty-object-type fixes - two set-state-in-effect cases (mount fetch, prop sync) suppressed with reasons Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI has been red because
next lintwas removed in Next.js 16 (it treatedlintas a project directory and exited before linting).npm run lint(eslint 9 flat config).no-explicit-any→ downgraded to warn for now so they can be typed incrementally.window.location.assigninstead of assigninghref(identical behavior),prefer-const,Record<string, never>for an empty props type.react-hooks/set-state-in-effecthits (mount fetch in outreach, prop→state sync in deal-selector) are suppressed with a comment rather than refactored.Verified locally:
npx eslint .→ 0 errors,npx tsc --noEmitpasses. Based onorigin/main; does not include the 2 unpushed local commits onmain.🤖 Generated with Claude Code