Implement ea3-ident.xml overrides#253
Closed
shizmob wants to merge 3 commits intodjhackersdev:masterfrom
Closed
Conversation
Contributor
Author
|
The import ordinals need verification for everything except AVS 2.15.8. |
icex2
reviewed
May 1, 2023
| options->app_config_path = "prop/app-config.xml"; | ||
| options->avs_config_path = "prop/avs-config.xml"; | ||
| options->ea3_config_path = "prop/ea3-config.xml"; | ||
| options->ea3_ident_path = "prop/ea3-ident.xml"; |
Contributor
There was a problem hiding this comment.
Default is ok, but I don't see any parsing for this in options_read_cmdline allowing users to set this one to a path (and file) of their choice.
Contributor
|
Closing as I picked up the work and continue driving it from a new PR: #272 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patchset implements support for overriding the EA3 config using
prop/ea3-ident.xml, a method already in use by alternative tools. It generalizes the approach so that any node is picked up and merged with the EA3 config instead of just<soft>and<id>for future expansion.