Repository navigation
Fix a stack overflow when saving a long XML attribute - #292
Open
peterswimm wants to merge 1 commit into
Open
peterswimm wants to merge 1 commit into
peterswimm wants to merge 1 commit into
Conversation
TinyXML writes the project through Tiny2NosStub's fprintf, which formatted every piece into a 256 byte stack buffer with vsprintf. An attribute longer than that, such as a sample with a very long file name, ran past it, overwriting the stack and leaving the project file cut short mid-write. Now it formats with vsnprintf, and prints anything longer into a heap buffer of the right size. Assisted-by: Claude (LLM)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
TinyXML writes the project through
Tiny2NosStub'sfprintf, which formatted every piece into a 256 byte stack buffer withvsprintf. An attribute longer than that, such as a sample with a very long file name, ran past it, overwriting the stack and leavinglgptsav.datcut short mid-write.Now it formats with
vsnprintf, and prints anything longer into a heap buffer of the right size.Type of change
How Has This Been Tested?
Built from master with this change and run on the device below.
Test Configuration:
Checklist:
sources/Application/Model/Project.h(will bump if asked)An LLM (Claude) was used to help find the bug and write the patch; I read the diff and tested it myself.