Repository navigation
Fix SamplePool::Reassign reporting a loaded print as failed - #291
Open
peterswimm wants to merge 1 commit into
Open
peterswimm wants to merge 1 commit into
peterswimm wants to merge 1 commit into
Conversation
Reassign treated loadSample's result as a bool, but loadSample returns SLOAD_OK, which is 0, on success. So every print that loaded returned -1, and FxPrinter::Run assigned that -1 to the instrument while saying "OK!": the instrument was left without its printed sample. It also unloaded the old copy whenever the file was already on disk, even when that file was not in the pool, which called unload(-1). Now it unloads only a sample the pool holds. Assisted-by: Claude (LLM)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
SamplePool::Reassignchecked the result ofloadSample()as a bool, butloadSample()returnsSLOAD_OK, which is 0, on success. So every print that loaded returned -1, andFxPrinter::Runassigned that -1 to the instrument while reporting "OK!": the instrument was left without its printed sample.It also unloaded the old copy whenever the file was already on disk, even when that file was not in the pool, which called
unload(-1). Now it unloads only a sample the pool holds.Type of change
How Has This Been Tested?
Built from master with this change and run on the device below.
Test Configuration:
Checklist:
sources/Application/Model/Project.h(will bump if asked)An LLM (Claude) was used to help find the bug and write the patch; I read the diff and tested it myself.